Skip to content

go_router should allow setting requestFocus #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 17 commits into from
Aug 9, 2023
Merged

go_router should allow setting requestFocus #4636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0f3bfa0
1
hannah-hyj Jul 27, 2023
fd8b12d
2
hannah-hyj Aug 2, 2023
e67036a
Update builder_test.dart
hannah-hyj Aug 3, 2023
30eae56
Update shell_route.dart
hannah-hyj Aug 3, 2023
68cd1a6
Create request_focus.dart
hannah-hyj Aug 3, 2023
9b3a098
bump verstion
hannah-hyj Aug 3, 2023
28fe484
Update pubspec.yaml
hannah-hyj Aug 3, 2023
5e58db7
Update builder.dart
hannah-hyj Aug 3, 2023
b66dcfc
Update packages/go_router/lib/src/builder.dart
hannah-hyj Aug 7, 2023
5576b21
resolve comments
hannah-hyj Aug 7, 2023
7e10266
1
hannah-hyj Aug 7, 2023
46d0169
Update router.dart
hannah-hyj Aug 7, 2023
fac1b21
Update router.dart
hannah-hyj Aug 7, 2023
627d79e
Update test_helpers.dart
hannah-hyj Aug 7, 2023
bb50ce6
1
hannah-hyj Aug 7, 2023
033a5ff
Update builder.dart
hannah-hyj Aug 9, 2023
f863e60
Merge branch 'main' of https://github.com/flutter/packages into 129581
hannah-hyj Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
1
  • Loading branch information
@hannah-hyj
hannah-hyj committed Aug 7, 2023
commit bb50ce6d58e532506a2a4dedc706470067011122
4 changes: 2 additions & 2 deletions packages/go_router/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ class RouteBuilder {

/// Whether or not the navigator created by this builder and it's new topmost route should request focus
/// when the new route is pushed onto the navigator.
///
///
/// Defaults to true.
Copy link
Contributor

@chunhtai chunhtai Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a link to navigator.requestfocus

Copy link
Member Author

@hannah-hyj hannah-hyj Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

///
///
/// {@macro flutter.widgets.navigator.requestFocus}
final bool requestFocus;

Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/lib/src/router.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ typedef GoExceptionHandler = void Function(
/// provided, go_router builds a default error screen to show the exception.
/// See [Error handling](https://pub.dev/documentation/go_router/latest/topics/Error%20handling-topic.html)
/// for more details.
///
///
/// To disable automatically requesting focus when new routes are pushed to the navigator, set `requestFocus` to false.
///
/// See also:
Expand Down