Skip to content

[go_router] Adds on exit #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Sep 18, 2023
Merged

[go_router] Adds on exit #4699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edc2726
[go_router] Adds on exitt push
chunhtai Aug 14, 2023
5e1236e
update
chunhtai Aug 14, 2023
47f43a4
update
chunhtai Aug 14, 2023
44d6694
fix test
chunhtai Aug 14, 2023
5f239bf
fix test
chunhtai Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@chunhtai
chunhtai committed Sep 18, 2023
commit 44d6694475963dbfcbceaa5f35e394bfda39bdff
1 change: 0 additions & 1 deletion packages/go_router/example/lib/on_exit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ final GoRouter _router = GoRouter(
context: context,
builder: (_) {
return AlertDialog(
title: const Text('Confirm'),
content: const Text('Are you sure to leave this page?'),
actions: <Widget>[
TextButton(
Expand Down
1 change: 1 addition & 0 deletions packages/go_router/example/test/on_exit_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ void main() {
await tester.tap(find.byType(BackButton));
await tester.pumpAndSettle();

expect(find.text('Are you sure to leave this page?'), findsOneWidget);
await tester.tap(find.text('Confirm'));
await tester.pumpAndSettle();
expect(find.byType(example.HomeScreen), findsOneWidget);
Expand Down