Skip to content

[url_launcher] migrating iOS tests from objc to swift #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Sep 11, 2023
Merged

[url_launcher] migrating iOS tests from objc to swift #4758

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2741de4
converting tests to swift
chrisdlangham Aug 22, 2023
495de26
converting unit tests to swift
chrisdlangham Aug 23, 2023
c898698
Merge branch 'main' into converting-url-launcher-ios-tests-to-swift
chrisdlangham Aug 23, 2023
6a6c8d5
updating change log
chrisdlangham Aug 23, 2023
761c6d9
making test classes final and private
chrisdlangham Aug 29, 2023
968a2f1
resolving merge conflicts
chrisdlangham Aug 30, 2023
13e339f
Merge branch 'main' into converting-url-launcher-ios-tests-to-swift
chrisdlangham Sep 8, 2023
11cfe4f
removing updates to changelog
chrisdlangham Sep 8, 2023
1228851
refactoring unit tests
chrisdlangham Sep 8, 2023
001f0b6
adjusting indentions
chrisdlangham Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
making test classes final and private
  • Loading branch information
@chrisdlangham
chrisdlangham committed Aug 29, 2023
commit 761c6d9dac0324a11fa547b47681c2658f807020
10 changes: 5 additions & 5 deletions packages/url_launcher/url_launcher_ios/example/ios/RunnerTests/URLLauncherTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import XCTest

@testable import url_launcher_ios

class URLLauncherTests: XCTestCase {
var plugin: FLTURLLauncherPlugin!
var launcher: FakeLauncher!
final class URLLauncherTests: XCTestCase {
private var plugin: FLTURLLauncherPlugin!
private var launcher: FakeLauncher!
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the test class become stateful in this migration? Stateful test fixtures are generally an anti-pattern, and making the object under test stateful is especially problematic.


override func setUp() {
launcher = FakeLauncher()
Expand Down Expand Up @@ -108,7 +108,7 @@ class URLLauncherTests: XCTestCase {

}

class FakeLauncher: NSObject, FULLauncher {
final fileprivate class FakeLauncher: NSObject, FULLauncher {
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need this to inherit from NSObject?

Copy link
Contributor Author

@chrisdlangham chrisdlangham Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes since the plugin is still in objective-c

var passedOptions: [UIApplication.OpenExternalURLOptionsKey: Any]?

func canOpen(_ url: URL) -> Bool {
Expand All @@ -124,7 +124,7 @@ class FakeLauncher: NSObject, FULLauncher {
}
}

class FakeFlutterBinaryMessenger: NSObject, FlutterBinaryMessenger {
final fileprivate class FakeFlutterBinaryMessenger: NSObject, FlutterBinaryMessenger {
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why does this class even exist? It's not used anywhere, and it wasn't in the Obj-C version.

Copy link
Contributor Author

@chrisdlangham chrisdlangham Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

func send(onChannel channel: String, message: Data?) {}

func send(
Expand Down