Skip to content

[google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Sep 11, 2023
Merged

[google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky #4768

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38b41f9
Added delay to address timing issue with info window display status u…
mossmana Aug 24, 2023
e8aced7
Attempting to fix TODO style
mossmana Aug 24, 2023
7222352
Fixed formatting issue
mossmana Aug 24, 2023
b9a655c
reverted removal of waitForValueMatchingPredicate
mossmana Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempting to fix TODO style
  • Loading branch information
@mossmana
mossmana committed Sep 11, 2023
commit e8aced7b1e51afb182fe158ec90fa5a5684885bb
2 changes: 1 addition & 1 deletion ..._maps_flutter/google_maps_flutter_android/example/integration_test/google_maps_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ void googleMapsTests() {

await tester.pumpAndSettle();

// TODO (mossmana): Adding this delay addresses
// TODO(mossmana): Adding this delay addresses
// https://github.com/flutter/flutter/issues/131783. It may be related
// to https://github.com/flutter/flutter/issues/54758 and should be
// re-evaluated when that issue is fixed.
Expand Down