Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
dec3d69
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
0e0333b
Merge remote-tracking branch 'upstream/main'
camsim99 May 2, 2023
bd7ac99
Merge remote-tracking branch 'upstream/main'
camsim99 May 3, 2023
5c3363b
Merge remote-tracking branch 'upstream/main'
camsim99 May 10, 2023
fed9621
Undo changes
camsim99 May 10, 2023
5aabe34
Merge remote-tracking branch 'upstream/main'
camsim99 May 12, 2023
2b9a352
Merge remote-tracking branch 'upstream/main'
camsim99 May 25, 2023
a1173da
Merge remote-tracking branch 'upstream/main'
camsim99 May 30, 2023
cbc3d6b
Merge remote-tracking branch 'upstream/main'
camsim99 May 30, 2023
cae5a4c
Merge remote-tracking branch 'upstream/main'
camsim99 Jun 1, 2023
72283db
Merge remote-tracking branch 'upstream/main'
camsim99 Jun 5, 2023
166a77c
Merge remote-tracking branch 'upstream/main'
camsim99 Jun 5, 2023
399780e
Merge remote-tracking branch 'upstream/main'
camsim99 Jun 14, 2023
8d5d0e7
Merge remote-tracking branch 'upstream/main'
camsim99 Jun 26, 2023
084d960
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 12, 2023
d2a59ac
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 17, 2023
a1422bf
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 17, 2023
bdd87a6
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 18, 2023
137a28b
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 19, 2023
bc0db5a
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 20, 2023
d04b466
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 21, 2023
a9cfe87
Merge remote-tracking branch 'upstream/main'
camsim99 Jul 24, 2023
a32def1
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 2, 2023
4785148
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 14, 2023
7a8fc69
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 15, 2023
b02e15f
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 15, 2023
c6e5868
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 17, 2023
0c0065a
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 28, 2023
9dfe259
Merge remote-tracking branch 'upstream/main'
camsim99 Aug 29, 2023
66117a3
Add impl
camsim99 Aug 29, 2023
d909e4b
Bump platform interfae requirement, versions, and update readme
camsim99 Aug 30, 2023
f99fc77
Add test
camsim99 Aug 30, 2023
20b7d33
Change video recording tests to video capture tests
camsim99 Aug 30, 2023
917d582
Merge branch 'main' into camx_vidcap
camsim99 Aug 30, 2023
f29b951
Fix test name
camsim99 Aug 30, 2023
a653810
Merge branch 'camx_vidcap' of github.com:camsim99/packages into camx_…
camsim99 Aug 30, 2023
1b6f439
Merge remote-tracking branch 'upstream/main' into camx_vidcap
camsim99 Sep 11, 2023
7a24ee7
Fix test
camsim99 Sep 11, 2023
5d9e038
format
camsim99 Sep 11, 2023
b7c7bbf
Clarify README
camsim99 Sep 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change video recording tests to video capture tests
  • Loading branch information
camsim99 committed Aug 30, 2023
commit 20b7d33eb48dd7432a84afb3d5ee29cf17576a83
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,8 @@ class AndroidCameraCameraX extends CameraPlatform {

/// Configures and starts a video recording. Returns silently without doing
/// anything if there is currently an active recording.
///
/// This method is deprecated in favour of [startVideoCapturing].
@override
Future<void> startVideoRecording(int cameraId,
{Duration? maxVideoDuration}) async {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -598,9 +598,9 @@ void main() {

group('video recording', () {
test(
'startVideoRecording binds video capture use case and starts the recording',
'startVideoCapture binds video capture use case and starts the recording',
() async {
//Set up mocks and constants.
// Set up mocks and constants.
final FakeAndroidCameraCameraX camera = FakeAndroidCameraCameraX();
camera.processCameraProvider = MockProcessCameraProvider();
camera.cameraSelector = MockCameraSelector();
Expand Down Expand Up @@ -628,7 +628,7 @@ void main() {
camera.cameraSelector!, <UseCase>[camera.videoCapture!]))
.thenAnswer((_) async => camera.camera!);

await camera.startVideoRecording(cameraId);
await camera.startVideoCapturing(const VideoCaptureOptions(cameraId));

verify(camera.processCameraProvider!.bindToLifecycle(
camera.cameraSelector!, <UseCase>[camera.videoCapture!]));
Expand All @@ -637,7 +637,7 @@ void main() {
});

test(
'startVideoRecording binds video capture use case and starts the recording'
'startVideoCapturing binds video capture use case and starts the recording'
' on first call, and does nothing on second call', () async {
// Set up mocks and constants.
final FakeAndroidCameraCameraX camera = FakeAndroidCameraCameraX();
Expand Down Expand Up @@ -667,14 +667,14 @@ void main() {
camera.cameraSelector!, <UseCase>[camera.videoCapture!]))
.thenAnswer((_) async => camera.camera!);

await camera.startVideoRecording(cameraId);
await camera.startVideoCapturing(const VideoCaptureOptions(cameraId));

verify(camera.processCameraProvider!.bindToLifecycle(
camera.cameraSelector!, <UseCase>[camera.videoCapture!]));
expect(camera.pendingRecording, equals(mockPendingRecording));
expect(camera.recording, mockRecording);

await camera.startVideoRecording(cameraId);
await camera.startVideoCapturing(const VideoCaptureOptions(cameraId));
// Verify that each of these calls happened only once.
verify(mockSystemServicesApi.getTempFilePath(camera.videoPrefix, '.temp'))
.called(1);
Expand All @@ -689,7 +689,8 @@ void main() {
'startVideoCapturing called with stream options starts image streaming',
() async {
// Set up mocks and constants.
final FakeAndroidCameraCameraX camera = FakeAndroidCameraCameraX();
final FakeAndroidCameraCameraX camera =
FakeAndroidCameraCameraX(shouldCreateDetachedObjectForTesting: true);
final MockProcessCameraProvider mockProcessCameraProvider =
MockProcessCameraProvider();
camera.processCameraProvider = mockProcessCameraProvider;
Expand Down