[Android] Introduces API 34 emulators for subset of tests #4820
Try filtering packages
- Loading branch information
commit 0026d0ecb48bdf57b2056f32cb151027e4569596
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Same as android_platform_tests.yaml with only packages currently requiring | ||
| # Android 33 due to test failures caused by running on Android 34 AVDs. | ||
| tasks: | ||
| - name: prepare tool | ||
| script: .ci/scripts/prepare_tool.sh | ||
| infra_step: true # Note infra steps failing prevents "always" from running. | ||
| - name: download Dart and Android deps | ||
| script: script/tool_runner.sh | ||
| infra_step: true | ||
| args: ["fetch-deps", "--android", "--supporting-target-platforms-only"] | ||
| - name: build examples | ||
| script: script/tool_runner.sh | ||
| args: ["build-examples", "--apk"] | ||
| - name: lint | ||
| script: script/tool_runner.sh | ||
| args: ["lint-android"] | ||
| # Native unit and native integration are split into two steps to allow for | ||
| # different exclusions. | ||
| # TODO(stuartmorgan): Eliminate the native unit test exclusion, and combine | ||
| # these steps. | ||
| - name: native unit tests | ||
| script: script/tool_runner.sh | ||
| args: ["native-test", "--android", "--no-integration", "--exclude=script/configs/exclude_native_unit_android.yaml"] | ||
| - name: native integration tests | ||
| script: script/tool_runner.sh | ||
| args: ["native-test", "--android", "--no-unit"] | ||
| - name: drive examples | ||
| script: script/tool_runner.sh | ||
| args: ["drive-examples", "--android", "--exclude=script/configs/exclude_integration_android.yaml,script/configs/exclude_integration_android_emulator.yaml", "--filter-packages-to=script/configs/still_requires_api_33_avd.yaml"] | ||
camsim99 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Running the tests of these packages on an AVD with Android 34 causes failures. | ||
| - file_selector | ||
| - path_provider |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these tasks aren't being passed either of the include/exclude flags, they will all run twice: once on the 34 shards and once on the 33 shards, even though there's no difference.
We should either pass the flags to everything, to keep all the tasks for a given plugin together, and running only in one place, or we should remove these two tasks from the 33 version, so all builds and lints run on the 34 shards.
I would vote for the former, for consistency, but either should work.