Skip to content

[ci] Convert version presubmit check to LUCI #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Aug 31, 2023
Merged

[ci] Convert version presubmit check to LUCI #4822

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6d90510
Add LUCI presubmit check
stuartmorgan-g Aug 31, 2023
0a7de2f
Remove Cirrus config and Dockerfile
stuartmorgan-g Aug 31, 2023
25f5116
Bogus change for testing
stuartmorgan-g Aug 31, 2023
c24d446
Merge branch 'main' into luci-version-check
yusuf-goog Aug 31, 2023
a3766c3
Move publishability to the end since it's slow
stuartmorgan-g Aug 31, 2023
94702b8
Revert sanity check change
stuartmorgan-g Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add LUCI presubmit check
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Aug 31, 2023
commit 6d905108910ead169826b220c1eef59f33f25f3b
7 changes: 3 additions & 4 deletions .ci/scripts/check_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
# found in the LICENSE file.
set -e

# For pre-submit, this is currently run in Cirrus; see TODO below.
# For pre-submit, check for missing or breaking changes that don't have a
# corresponding override label.
# For post-submit, ignore platform interface breaking version changes and
# missing version/CHANGELOG detection since PR-level overrides aren't available
# in post-submit.
if [[ $LUCI_PR == "" ]]; then
./script/tool_runner.sh version-check --ignore-platform-interface-breaks
else
# TODO(stuartmorgan): Migrate this check from Cirrus. See
# https://github.com/flutter/flutter/issues/130076
:
./script/tool_runner.sh version-check --check-for-missing-changes --pr-labels="$PR_OVERRIDE_LABELS"
fi