Skip to content

[camera_android] Removes usage of _ambiguate method in tests #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Sep 22, 2023
Merged

[camera_android] Removes usage of _ambiguate method in tests #4948

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd42218
[camera_android] Removes usage of `_ambiguate` method in tests
nilsreichardt Sep 19, 2023
8a46da7
Also fix usage
nilsreichardt Sep 19, 2023
91cb3f0
Add file
nilsreichardt Sep 19, 2023
be0a16e
Remove changelog
nilsreichardt Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add file
  • Loading branch information
@nilsreichardt
nilsreichardt committed Sep 19, 2023
commit 91cb3f09a3e81b375d9e3116e9863a95292deebe
9 changes: 1 addition & 8 deletions packages/camera/camera_android/test/method_channel_mock.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ class MethodChannelMock {
this.delay,
required this.methods,
}) : methodChannel = MethodChannel(channelName) {
_ambiguate(TestDefaultBinaryMessengerBinding.instance)!
.defaultBinaryMessenger
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
.setMockMethodCallHandler(methodChannel, _handler);
}

Expand All @@ -39,9 +38,3 @@ class MethodChannelMock {
});
}
}

/// This allows a value of type T or T? to be treated as a value of type T?.
///
/// We use this so that APIs that have become non-nullable can still be used
/// with `!` and `?` on the stable branch.
T? _ambiguate<T>(T? value) => value;