Skip to content

[two_dimensional_scrollables] Add TableSpanPadding #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Oct 26, 2023
Merged

[two_dimensional_scrollables] Add TableSpanPadding #5039

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d357abd
Add TableSpanPadding
Piinks Sep 29, 2023
c62a209
++
Piinks Oct 10, 2023
0c09049
More edge cases
Piinks Oct 13, 2023
d8040f2
++
Piinks Oct 18, 2023
2245e8c
Capture span decoration consuming padding or not
Piinks Oct 18, 2023
dfbda1c
Nits
Piinks Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
@Piinks
Piinks committed Oct 13, 2023
commit c62a209cbc07b11e578225251d3e6d85317a5e29
2 changes: 1 addition & 1 deletion packages/two_dimensional_scrollables/lib/src/table_view/table.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ class RenderTableViewport extends RenderTwoDimensionalViewport {
}) {
Copy link
Member

@goderbauer goderbauer Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain to me how the padding is taken into account when calculating the start and end (input to this method) cells?

Copy link
Member

@goderbauer goderbauer Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_Span.trailingOffset is used to calculate the start and end, which includes the padding. There are even tests for this case. Awesome!

// TODO(Piinks): Assert here or somewhere else merged cells cannot span
// pinned and unpinned cells (for merged cell follow-up), https://github.com/flutter/flutter/issues/131224
late double yPaintOffset = -offset.dy;
double yPaintOffset = -offset.dy;
for (int row = start.row; row <= end.row; row += 1) {
double xPaintOffset = -offset.dx;
final double rowHeight = _rowMetrics[row]!.extent;
Expand Down