Skip to content

[video_player] Improve macOS frame management #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 15 commits into from
Nov 16, 2023
Merged

[video_player] Improve macOS frame management #5078

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8dde36b
[video_player] Avoid returning no frame on macOS
stuartmorgan-g Oct 4, 2023
a1d46cb
Factor out display link code for easier use
stuartmorgan-g Oct 5, 2023
eba10b9
Fix seeking while paused
stuartmorgan-g Oct 5, 2023
b24e792
Minor improvements
stuartmorgan-g Oct 5, 2023
1a489e5
Fix and add tests
stuartmorgan-g Oct 5, 2023
419859d
Autoformat
stuartmorgan-g Oct 5, 2023
109ca02
Version bump
stuartmorgan-g Oct 5, 2023
1a59cc1
Bump iOS OCMock version
stuartmorgan-g Oct 6, 2023
c9ca774
Fix accidental registrar duplication in tests
stuartmorgan-g Oct 6, 2023
b17b65a
Merge branch 'main' into video-player-macos-fallback-frame
stuartmorgan-g Nov 9, 2023
8295980
Update new unit tests for changes on main
stuartmorgan-g Nov 9, 2023
08d7497
Merge branch 'main' into video-player-macos-fallback-frame
stuartmorgan-g Nov 14, 2023
8f7dcbe
Add running implementations
stuartmorgan-g Nov 14, 2023
b6a55a0
Added more comments
stuartmorgan-g Nov 14, 2023
9ce3e8c
Add issue link
stuartmorgan-g Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix accidental registrar duplication in tests
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g authored Oct 6, 2023
commit c9ca7745233b59e1a241a8cd5c000bf543bcaec8
4 changes: 2 additions & 2 deletions packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ - (void)testSeekToWhilePausedStartsDisplayLinkTemporarily {
NSObject<FlutterTextureRegistry> *mockTextureRegistry =
OCMProtocolMock(@protocol(FlutterTextureRegistry));
NSObject<FlutterPluginRegistrar> *registrar =
[GetPluginRegistry() registrarForPlugin:@"SeekToInvokestextureFrameAvailable"];
[GetPluginRegistry() registrarForPlugin:@"SeekToWhilePausedStartsDisplayLinkTemporarily"];
NSObject<FlutterPluginRegistrar> *partialRegistrar = OCMPartialMock(registrar);
OCMStub([partialRegistrar textures]).andReturn(mockTextureRegistry);
FVPDisplayLink *mockDisplayLink =
Expand Down Expand Up @@ -259,7 +259,7 @@ - (void)testSeekToWhilePlayingDoesNotStopDisplayLink {
NSObject<FlutterTextureRegistry> *mockTextureRegistry =
OCMProtocolMock(@protocol(FlutterTextureRegistry));
NSObject<FlutterPluginRegistrar> *registrar =
[GetPluginRegistry() registrarForPlugin:@"SeekToInvokestextureFrameAvailable"];
[GetPluginRegistry() registrarForPlugin:@"SeekToWhilePlayingDoesNotStopDisplayLink"];
NSObject<FlutterPluginRegistrar> *partialRegistrar = OCMPartialMock(registrar);
OCMStub([partialRegistrar textures]).andReturn(mockTextureRegistry);
FVPDisplayLink *mockDisplayLink =
Expand Down