Skip to content

[process] Import the process package #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Oct 9, 2023
Merged

[process] Import the process package #5095

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5dc9167
Initial, unchanged snapshot of original repo.
stuartmorgan-g Oct 9, 2023
52edc12
Remove CI and repo meta-docs
stuartmorgan-g Oct 9, 2023
923b667
Update license format to match repo conventions
stuartmorgan-g Oct 9, 2023
629503c
Update pubspec for repo conventions
stuartmorgan-g Oct 9, 2023
97f4fe6
Set tests to non-web-only
stuartmorgan-g Oct 9, 2023
ce7730a
Repo metadata
stuartmorgan-g Oct 9, 2023
d4bfcf6
Remove platform and process from dependency exception list
stuartmorgan-g Oct 9, 2023
6efe939
Remove analysis options
stuartmorgan-g Oct 9, 2023
7098edb
autoformat
stuartmorgan-g Oct 9, 2023
d39df0a
Version bump
stuartmorgan-g Oct 9, 2023
53d4f88
Update tests to use throwsA
stuartmorgan-g Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests to use throwsA
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Oct 9, 2023
commit 53d4f883d60cf9fe9d1b83809af89390b65b63e2
252 changes: 129 additions & 123 deletions packages/process/test/src/interface/common_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,31 +205,37 @@ void main() {
test('not found with throwOnFailure throws exception with match state',
() {
const String command = 'foo.exe';
io.ProcessException error;
try {
getExecutablePath(
command,
workingDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
);
fail('Expected to throw');
} on io.ProcessException catch (err) {
error = err;
}

expect(error, isA<ProcessPackageExecutableNotFoundException>());
final ProcessPackageExecutableNotFoundException notFoundException =
error as ProcessPackageExecutableNotFoundException;
expect(notFoundException.candidates, isEmpty);
expect(notFoundException.workingDirectory, equals(workingDir.path));
expect(
error.toString(),
contains(' Working Directory: C:\\.tmp_rand0\\work_dir_rand0\n'
' Search Path:\n'
' C:\\.tmp_rand0\\dir1_rand0\n'
' C:\\.tmp_rand0\\dir2_rand0\n'));
() => getExecutablePath(
command,
workingDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
),
throwsA(isA<ProcessPackageExecutableNotFoundException>()
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.candidates,
'candidates',
isEmpty)
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.workingDirectory,
'workingDirectory',
equals(workingDir.path))
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.toString(),
'toString',
contains(
' Working Directory: C:\\.tmp_rand0\\work_dir_rand0\n'
' Search Path:\n'
' C:\\.tmp_rand0\\dir1_rand0\n'
' C:\\.tmp_rand0\\dir2_rand0\n'))));
});

test('when path has spaces', () {
Expand Down Expand Up @@ -341,31 +347,36 @@ void main() {
test('not found with throwOnFailure throws exception with match state',
() {
const String command = 'foo';
io.ProcessException error;
try {
getExecutablePath(
command,
workingDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
);
fail('Expected to throw');
} on io.ProcessException catch (err) {
error = err;
}

expect(error, isA<ProcessPackageExecutableNotFoundException>());
final ProcessPackageExecutableNotFoundException notFoundException =
error as ProcessPackageExecutableNotFoundException;
expect(notFoundException.candidates, isEmpty);
expect(notFoundException.workingDirectory, equals(workingDir.path));
expect(
error.toString(),
contains(' Working Directory: /.tmp_rand0/work_dir_rand0\n'
' Search Path:\n'
' /.tmp_rand0/dir1_rand0\n'
' /.tmp_rand0/dir2_rand0\n'));
() => getExecutablePath(
command,
workingDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
),
throwsA(isA<ProcessPackageExecutableNotFoundException>()
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.candidates,
'candidates',
isEmpty)
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.workingDirectory,
'workingDirectory',
equals(workingDir.path))
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.toString(),
'toString',
contains(' Working Directory: /.tmp_rand0/work_dir_rand0\n'
' Search Path:\n'
' /.tmp_rand0/dir1_rand0\n'
' /.tmp_rand0/dir2_rand0\n'))));
});

test('when path has spaces', () {
Expand Down Expand Up @@ -477,52 +488,48 @@ void main() {
// All executable permissions, but not readable
io.Process.runSync('chmod', <String>['0311', '--', command4.path]);

io.ProcessException error;
try {
getExecutablePath(
'command',
tmpDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
);
fail('Expected to throw');
} on io.ProcessException catch (err) {
error = err;
}

expect(error, isA<ProcessPackageExecutableNotFoundException>());
final ProcessPackageExecutableNotFoundException notFoundException =
error as ProcessPackageExecutableNotFoundException;
expect(
notFoundException.candidates,
equals(<String>[
'${tmpDir.path}/path1/command',
'${tmpDir.path}/path2/command',
'${tmpDir.path}/path3/command',
'${tmpDir.path}/path4/command',
'${tmpDir.path}/path5/command',
]));
expect(
error.toString(),
equals(
'ProcessPackageExecutableNotFoundException: Found candidates, but lacked sufficient permissions to execute "command".\n'
' Command: command\n'
' Working Directory: ${tmpDir.path}\n'
' Candidates:\n'
' ${tmpDir.path}/path1/command\n'
' ${tmpDir.path}/path2/command\n'
' ${tmpDir.path}/path3/command\n'
' ${tmpDir.path}/path4/command\n'
' ${tmpDir.path}/path5/command\n'
' Search Path:\n'
' ${tmpDir.path}/path1\n'
' ${tmpDir.path}/path2\n'
' ${tmpDir.path}/path3\n'
' ${tmpDir.path}/path4\n'
' ${tmpDir.path}/path5\n',
),
);
() => getExecutablePath(
'command',
tmpDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
),
throwsA(isA<ProcessPackageExecutableNotFoundException>()
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.candidates,
'candidates',
equals(<String>[
'${tmpDir.path}/path1/command',
'${tmpDir.path}/path2/command',
'${tmpDir.path}/path3/command',
'${tmpDir.path}/path4/command',
'${tmpDir.path}/path5/command',
]))
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.toString(),
'toString',
contains(
'ProcessPackageExecutableNotFoundException: Found candidates, but lacked sufficient permissions to execute "command".\n'
' Command: command\n'
' Working Directory: ${tmpDir.path}\n'
' Candidates:\n'
' ${tmpDir.path}/path1/command\n'
' ${tmpDir.path}/path2/command\n'
' ${tmpDir.path}/path3/command\n'
' ${tmpDir.path}/path4/command\n'
' ${tmpDir.path}/path5/command\n'
' Search Path:\n'
' ${tmpDir.path}/path1\n'
' ${tmpDir.path}/path2\n'
' ${tmpDir.path}/path3\n'
' ${tmpDir.path}/path4\n'
' ${tmpDir.path}/path5\n'))));
});

test('Test that finding no executable paths throws with proper information',
Expand All @@ -533,37 +540,36 @@ void main() {
return;
}

io.ProcessException error;
try {
getExecutablePath(
'non-existent-command',
tmpDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
);
fail('Expected to throw');
} on io.ProcessException catch (err) {
error = err;
}

expect(error, isA<ProcessPackageExecutableNotFoundException>());
final ProcessPackageExecutableNotFoundException notFoundException =
error as ProcessPackageExecutableNotFoundException;
expect(notFoundException.candidates, isEmpty);
expect(
error.toString(),
equals(
'ProcessPackageExecutableNotFoundException: Failed to find "non-existent-command" in the search path.\n'
' Command: non-existent-command\n'
' Working Directory: ${tmpDir.path}\n'
' Search Path:\n'
' ${tmpDir.path}/path1\n'
' ${tmpDir.path}/path2\n'
' ${tmpDir.path}/path3\n'
' ${tmpDir.path}/path4\n'
' ${tmpDir.path}/path5\n'),
);
() => getExecutablePath(
'non-existent-command',
tmpDir.path,
platform: platform,
fs: fs,
throwOnFailure: true,
),
throwsA(isA<ProcessPackageExecutableNotFoundException>()
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.candidates,
'candidates',
isEmpty)
.having(
(ProcessPackageExecutableNotFoundException
notFoundException) =>
notFoundException.toString(),
'toString',
contains(
'ProcessPackageExecutableNotFoundException: Failed to find "non-existent-command" in the search path.\n'
' Command: non-existent-command\n'
' Working Directory: ${tmpDir.path}\n'
' Search Path:\n'
' ${tmpDir.path}/path1\n'
' ${tmpDir.path}/path2\n'
' ${tmpDir.path}/path3\n'
' ${tmpDir.path}/path4\n'
' ${tmpDir.path}/path5\n'))));
});
});
}
Expand Down