Skip to content

[two_dimensional_scrollables] Add borderRadius support to TableSpanDecoration #5184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 8 commits into from
Nov 3, 2023
Merged

[two_dimensional_scrollables] Add borderRadius support to TableSpanDecoration #5184

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b8ac0c
Initial, edges need incorporating
Piinks Oct 18, 2023
8a411ec
++
Piinks Oct 19, 2023
c9d08dc
Commit to switch
Piinks Nov 3, 2023
f5a19d4
Merge remote-tracking branch 'upstream/main' into decorationRadius
Piinks Nov 3, 2023
2243ea2
Finish
Piinks Nov 3, 2023
6f45ee7
++
Piinks Nov 3, 2023
0b935b4
Format
Piinks Nov 3, 2023
6076126
Review feedback
Piinks Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
@Piinks
Piinks committed Oct 19, 2023
commit 8a411ececebe866bdb19f8655200fbaf7c0379f1
20 changes: 0 additions & 20 deletions packages/two_dimensional_scrollables/lib/src/table_view/table_span.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,6 @@ class TableSpanDecoration {
/// [TableSpanDecorationPaintDetails.rect] containing all the other unpinned
/// cells.
void paint(TableSpanDecorationPaintDetails details) {
// TODO(Piinks): Incorporate leading/trailing edge
if (color != null) {
final Paint paint = Paint()
..color = color!
Expand Down Expand Up @@ -345,7 +344,6 @@ class TableSpanBorder {
TableSpanDecorationPaintDetails details,
BorderRadius? borderRadius,
) {
// TODO(Piinks): Incorporate leading/trailing edge
final AxisDirection axisDirection = details.axisDirection;
switch (axisDirectionToAxis(axisDirection)) {
case Axis.horizontal:
Expand Down Expand Up @@ -386,26 +384,8 @@ class TableSpanDecorationPaintDetails {
required this.canvas,
required this.rect,
required this.axisDirection,
this.isLeadingEdge = false,
this.isTrailingEdge = false,
});

/// Whether or not [rect] contains the leading edge of the [TableSpan]. This
/// is used to determine the application of
/// [TableSpanDecoration.borderRadius], which only applies to the ends of a
/// row or column.
///
/// Defaults to false.
final bool isLeadingEdge;

/// Whether or not [rect] contains the trailing edge of the [TableSpan]. This
/// is used to determine the application of
/// [TableSpanDecoration.borderRadius], which only applies to the ends of a
/// row or column.
///
/// Defaults to false.
final bool isTrailingEdge;

/// The [Canvas] that the [TableSpanDecoration] will be painted to.
final Canvas canvas;

Expand Down