Skip to content

Add '--no-tree-shake-icons' option to BenchmarkServer #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 7 commits into from
Oct 20, 2023
Merged

Add '--no-tree-shake-icons' option to BenchmarkServer #5186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
015277f
Add '--no-tree-shake-icons' option to `BenchmarkServer`
kenzieschmoll Oct 19, 2023
19e3523
Modify test to set `treeShakeIcons: false`
kenzieschmoll Oct 19, 2023
9ec2c8a
Merge branch 'main' into noTreeShakeIcons
kenzieschmoll Oct 19, 2023
00f06c6
fix lints
kenzieschmoll Oct 19, 2023
a94b1a5
Merge branch 'noTreeShakeIcons' of github.com:kenzieschmoll/packages …
kenzieschmoll Oct 19, 2023
fb8448d
update changelog and pubspec version
kenzieschmoll Oct 19, 2023
fd89a6c
formatting
kenzieschmoll Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lints
  • Loading branch information
@kenzieschmoll
kenzieschmoll committed Oct 19, 2023
commit 00f06c68224e42c4865fbf761c26a990cd04b9fd
2 changes: 1 addition & 1 deletion packages/web_benchmarks/lib/src/browser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ String _findSystemChromeExecutable() {
} else if (io.Platform.isWindows) {
const String kWindowsExecutable = r'Google\Chrome\Application\chrome.exe';
final List<String> kWindowsPrefixes = <String>[
for (String? item in <String?>[
for (final String? item in <String?>[
io.Platform.environment['LOCALAPPDATA'],
io.Platform.environment['PROGRAMFILES'],
io.Platform.environment['PROGRAMFILES(X86)'],
Expand Down
2 changes: 1 addition & 1 deletion packages/web_benchmarks/testing/test_app/lib/icon_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class _IconGeneratorPageState extends State<IconGeneratorPage> {
@override
Widget build(BuildContext context) {
return Column(
children: [
children: <Widget>[
TextField(
onSubmitted: (String value) {
final int codePointAsInt =
Expand Down