Skip to content

[go_router] Fixes crashes when dynamically updates routing tables wit… #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Nov 2, 2023
Merged

[go_router] Fixes crashes when dynamically updates routing tables wit… #5242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb9a304
[go_router] Fixes crashes when dynamically updates routing tables wit…
chunhtai Oct 26, 2023
07203fe
format
chunhtai Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format
  • Loading branch information
@chunhtai
chunhtai committed Nov 2, 2023
commit 07203fecde2bd7193876eeaf25c461cc951964d7
73 changes: 39 additions & 34 deletions packages/go_router/test/routing_config_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,41 +108,46 @@ void main() {
});

testWidgets('routing config works with named route',
(WidgetTester tester) async {
final ValueNotifier<RoutingConfig> config = ValueNotifier<RoutingConfig>(
RoutingConfig(
routes: <RouteBase>[
GoRoute(path: '/', builder: (_, __) => const Text('home')),
GoRoute(path: '/abc', name: 'abc', builder: (_, __) => const Text('/abc')),
],
),
);
final GoRouter router = await createRouterWithRoutingConfig(
config,
tester,
errorBuilder: (_, __) => const Text('error'),
);
expect(find.text('home'), findsOneWidget);
// Sanity check.
router.goNamed('abc');
await tester.pumpAndSettle();
expect(find.text('/abc'), findsOneWidget);
(WidgetTester tester) async {
final ValueNotifier<RoutingConfig> config = ValueNotifier<RoutingConfig>(
RoutingConfig(
routes: <RouteBase>[
GoRoute(path: '/', builder: (_, __) => const Text('home')),
GoRoute(
path: '/abc',
name: 'abc',
builder: (_, __) => const Text('/abc')),
],
),
);
final GoRouter router = await createRouterWithRoutingConfig(
config,
tester,
errorBuilder: (_, __) => const Text('error'),
);
expect(find.text('home'), findsOneWidget);
// Sanity check.
router.goNamed('abc');
await tester.pumpAndSettle();
expect(find.text('/abc'), findsOneWidget);

config.value = RoutingConfig(
routes: <RouteBase>[
GoRoute(path: '/', name: 'home', builder: (_, __) => const Text('home')),
GoRoute(path: '/abc', name: 'def',builder: (_, __) => const Text('def')),
],
);
await tester.pumpAndSettle();
expect(find.text('def'), findsOneWidget);
config.value = RoutingConfig(
routes: <RouteBase>[
GoRoute(
path: '/', name: 'home', builder: (_, __) => const Text('home')),
GoRoute(
path: '/abc', name: 'def', builder: (_, __) => const Text('def')),
],
);
await tester.pumpAndSettle();
expect(find.text('def'), findsOneWidget);

router.goNamed('home');
await tester.pumpAndSettle();
expect(find.text('home'), findsOneWidget);
router.goNamed('home');
await tester.pumpAndSettle();
expect(find.text('home'), findsOneWidget);

router.goNamed('def');
await tester.pumpAndSettle();
expect(find.text('def'), findsOneWidget);
});
router.goNamed('def');
await tester.pumpAndSettle();
expect(find.text('def'), findsOneWidget);
});
}