-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[camera_avfoundation] Set highest available resolution for ResolutionPreset.Max #5245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 25 commits into
flutter:main
from
sergeidesenko:camera_avfoundation-max-resolution
Mar 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
01ad812
Set higher resolution when using max preset
sergeidesenko 5f5cabc
Merge remote-tracking branch 'upstream/main' into camera_avfoundation…
sergeidesenko f9f302f
chore: update changelog
sergeidesenko e5a33f6
chore: update changelog and pubspec
sergeidesenko d3ce411
refactor: add comments
sergeidesenko 5813f25
chore: update pubspec
sergeidesenko 60e043a
feat(tests): add convenience method for camera init
sergeidesenko 9830404
feat(tests): add tests for setting resolutionPresets
sergeidesenko 87b0c59
chore(tests): add tests file to .pbxproj
sergeidesenko 0c29019
chore: fix formatting for updated files
sergeidesenko ae0210f
fix: don't update the changelog
sergeidesenko 0c8b21a
refactor: remove todo and renaming
sergeidesenko 37ffaa7
Merge remote-tracking branch 'upstream/main' into camera_avfoundation…
sergeidesenko 70deac4
Merge branch 'main' into camera_avfoundation-max-resolution
sergeidesenko 0fe1ac7
feat: add tests for different resolution presets
sergeidesenko c314755
refactor: update comment
sergeidesenko ec1b896
refactor: change tests to use DI
sergeidesenko 5e6f1f5
refactor: rename method
sergeidesenko decce1e
refactor: rename method
sergeidesenko 832cc7b
refactor: cleaner DI
sergeidesenko ddfe778
refactor: update comments
sergeidesenko 5c01c8c
refactor: update comment to match arguments
sergeidesenko 0c40901
refactor: rename types
sergeidesenko 42e9cfa
Merge branch 'main' into camera_avfoundation-max-resolution
sergeidesenko 8e019b3
refactor: address code review
sergeidesenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(tests): add convenience method for camera init
- Loading branch information
commit 60e043ad06532992758be4343f57ba873d19b04a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here and below. (If this is meant to say that this is stubbing it out with a no-op, the comment should be more explicit.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed