Skip to content

[pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 19 commits into from
Nov 17, 2023
Merged

[pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments #5355

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bff1449
isEnum, isClass, fix swift casting, default values
tarrinneal Nov 11, 2023
ce7dae4
will clean up
tarrinneal Nov 11, 2023
08c4c46
a little cleaner
tarrinneal Nov 11, 2023
f8d031f
const
tarrinneal Nov 11, 2023
5ee937e
rename klass and enu
tarrinneal Nov 13, 2023
44b7185
parameters
tarrinneal Nov 13, 2023
ec760f3
better Parameter making
tarrinneal Nov 14, 2023
dca289e
more better
tarrinneal Nov 14, 2023
e5df62f
$_
tarrinneal Nov 14, 2023
dee2d8f
new prefix, rename codec, add tests bump version
tarrinneal Nov 15, 2023
04a96f5
Merge branch 'main' of github.com:flutter/packages into optional-default
tarrinneal Nov 15, 2023
e587325
fix
tarrinneal Nov 15, 2023
0b2a21f
forgot these ones
tarrinneal Nov 15, 2023
9e5368c
[dart]
tarrinneal Nov 15, 2023
1f02129
-' '
tarrinneal Nov 15, 2023
11deb53
nits
tarrinneal Nov 17, 2023
7c09a31
Merge branch 'main' of github.com:flutter/packages into optional-default
tarrinneal Nov 17, 2023
e6ad15b
FlutterError cpp fix
tarrinneal Nov 17, 2023
0b4fe6f
update changelog
tarrinneal Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FlutterError cpp fix
  • Loading branch information
@tarrinneal
tarrinneal committed Nov 17, 2023
commit e6ad15b865726219b0a61bdd1f8a8de624d0ee82
17 changes: 11 additions & 6 deletions packages/pigeon/lib/cpp_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ class CppHeaderGenerator extends StructuredGenerator<CppOptions> {
final bool hasFlutterApi = root.apis.any((Api api) =>
api.methods.isNotEmpty && api.location == ApiLocation.flutter);

_writeFlutterError(indent);
if (hasHostApi) {
_writeErrorOr(indent, friends: root.apis.map((Api api) => api.name));
}
Expand Down Expand Up @@ -510,11 +511,7 @@ class CppHeaderGenerator extends StructuredGenerator<CppOptions> {
indent.newln();
}

void _writeErrorOr(Indent indent,
{Iterable<String> friends = const <String>[]}) {
final String friendLines = friends
.map((String className) => '\tfriend class $className;')
.join('\n');
void _writeFlutterError(Indent indent) {
indent.format('''

class FlutterError {
Expand All @@ -534,7 +531,15 @@ class FlutterError {
\tstd::string code_;
\tstd::string message_;
\tflutter::EncodableValue details_;
};
};''');
}

void _writeErrorOr(Indent indent,
{Iterable<String> friends = const <String>[]}) {
final String friendLines = friends
.map((String className) => '\tfriend class $className;')
.join('\n');
indent.format('''

template<class T> class ErrorOr {
public:
Expand Down