Skip to content

[google_sign_in] Add server auth code retrieval to gis_client #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Nov 30, 2023
Merged

[google_sign_in] Add server auth code retrieval to gis_client #5358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da5372e
Adds server auth code retrieval to google_sign_in_web.
T-P-F Nov 9, 2023
fb72f8f
Add web_only.dart to easily access web-only methods from the plugin.
ditman Nov 9, 2023
78bdab2
Add tests for requestServerAuthCode call.
ditman Nov 10, 2023
700f75d
Make CI happy.
ditman Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for requestServerAuthCode call.
  • Loading branch information
@ditman
ditman committed Nov 10, 2023
commit 78bdab2a207d9400d4da4ca09b0bdfdd55a8cc84
18 changes: 18 additions & 0 deletions ...s/google_sign_in/google_sign_in_web/example/integration_test/google_sign_in_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,24 @@ void main() {
expect(arguments.elementAt(1), someAccessToken);
});
});

group('requestServerAuthCode', () {
const String someAuthCode = '50m3_4u7h_c0d3';

setUp(() {
plugin.initWithParams(options);
});

testWidgets('passes-through call to gis client', (_) async {
mockito
.when(mockGis.requestServerAuthCode())
.thenAnswer((_) => Future<String>.value(someAuthCode));

final String? serverAuthCode = await plugin.requestServerAuthCode();

expect(serverAuthCode, someAuthCode);
});
});
});

group('userDataEvents', () {
Expand Down
23 changes: 22 additions & 1 deletion ...le_sign_in/google_sign_in_web/example/integration_test/google_sign_in_web_test.mocks.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Mocks generated by Mockito 5.4.0 from annotations
// Mocks generated by Mockito 5.4.1 from annotations
// in google_sign_in_web_integration_tests/integration_test/google_sign_in_web_test.dart.
// Do not manually edit this file.

// @dart=2.19

// ignore_for_file: no_leading_underscores_for_library_prefixes
import 'dart:async' as _i4;

Expand Down Expand Up @@ -47,6 +49,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValueForMissingStub:
_i4.Future<_i2.GoogleSignInUserData?>.value(),
) as _i4.Future<_i2.GoogleSignInUserData?>);

@override
_i4.Future<void> renderButton(
Object? parent,
Expand All @@ -63,6 +66,17 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValue: _i4.Future<void>.value(),
returnValueForMissingStub: _i4.Future<void>.value(),
) as _i4.Future<void>);

@override
_i4.Future<String?> requestServerAuthCode() => (super.noSuchMethod(
Invocation.method(
#requestServerAuthCode,
[],
),
returnValue: _i4.Future<String?>.value(),
returnValueForMissingStub: _i4.Future<String?>.value(),
) as _i4.Future<String?>);

@override
_i4.Future<_i2.GoogleSignInUserData?> signIn() => (super.noSuchMethod(
Invocation.method(
Expand All @@ -73,6 +87,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValueForMissingStub:
_i4.Future<_i2.GoogleSignInUserData?>.value(),
) as _i4.Future<_i2.GoogleSignInUserData?>);

@override
_i2.GoogleSignInTokenData getTokens() => (super.noSuchMethod(
Invocation.method(
Expand All @@ -94,6 +109,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
),
),
) as _i2.GoogleSignInTokenData);

@override
_i4.Future<void> signOut() => (super.noSuchMethod(
Invocation.method(
Expand All @@ -103,6 +119,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValue: _i4.Future<void>.value(),
returnValueForMissingStub: _i4.Future<void>.value(),
) as _i4.Future<void>);

@override
_i4.Future<void> disconnect() => (super.noSuchMethod(
Invocation.method(
Expand All @@ -112,6 +129,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValue: _i4.Future<void>.value(),
returnValueForMissingStub: _i4.Future<void>.value(),
) as _i4.Future<void>);

@override
_i4.Future<bool> isSignedIn() => (super.noSuchMethod(
Invocation.method(
Expand All @@ -121,6 +139,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValue: _i4.Future<bool>.value(false),
returnValueForMissingStub: _i4.Future<bool>.value(false),
) as _i4.Future<bool>);

@override
_i4.Future<void> clearAuthCache() => (super.noSuchMethod(
Invocation.method(
Expand All @@ -130,6 +149,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValue: _i4.Future<void>.value(),
returnValueForMissingStub: _i4.Future<void>.value(),
) as _i4.Future<void>);

@override
_i4.Future<bool> requestScopes(List<String>? scopes) => (super.noSuchMethod(
Invocation.method(
Expand All @@ -139,6 +159,7 @@ class MockGisSdkClient extends _i1.Mock implements _i3.GisSdkClient {
returnValue: _i4.Future<bool>.value(false),
returnValueForMissingStub: _i4.Future<bool>.value(false),
) as _i4.Future<bool>);

@override
_i4.Future<bool> canAccessScopes(
List<String>? scopes,
Expand Down