Skip to content

[webview_flutter] Support for handling basic authentication requests (Platform Interface) #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 48 commits into from
Nov 20, 2023
Merged

[webview_flutter] Support for handling basic authentication requests (Platform Interface) #5362

Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
517e9d4
Implement http basic auth
JeroenWeener Aug 10, 2023
967879b
Apply feedback
JeroenWeener Aug 28, 2023
c8624c0
Create HttpAuthHandlerTest.java
JeroenWeener Aug 29, 2023
4f3574d
Format java files
JeroenWeener Aug 29, 2023
1e7f785
Regenerate build_runner files
JeroenWeener Aug 29, 2023
131bc56
Implement feedback
JeroenWeener Sep 11, 2023
bc01be4
Remove redundant key in `Info.plist`
JeroenWeener Sep 11, 2023
67aa00e
Update example apps
JeroenWeener Sep 11, 2023
32496d0
Implement http basic auth
JeroenWeener Aug 10, 2023
aeb8708
Apply feedback
JeroenWeener Aug 28, 2023
fffc4c7
Create HttpAuthHandlerTest.java
JeroenWeener Aug 29, 2023
b455040
Format java files
JeroenWeener Aug 29, 2023
2aa9bfe
Regenerate build_runner files
JeroenWeener Aug 29, 2023
db286ba
Implement feedback
JeroenWeener Sep 11, 2023
467feb3
Remove redundant key in `Info.plist`
JeroenWeener Sep 11, 2023
dad8ae6
Update example apps
JeroenWeener Sep 11, 2023
6f3d802
Merge branch 'webview-auth-request' of https://github.com/andreisas06…
JeroenWeener Nov 1, 2023
0fef591
Add platform interface dev dependency to example
JeroenWeener Nov 1, 2023
b2a4fbb
Merge branch 'main' into webview-auth-request
JeroenWeener Nov 1, 2023
ce35d9b
Update packages/webview_flutter/webview_flutter_platform_interface/li…
bparrishMines Nov 8, 2023
fc32898
Merge branch 'main' of github.com:flutter/packages into webview-auth-…
bparrishMines Nov 8, 2023
4673e65
Merge branch 'webview-auth-request' of github.com:andreisas06/package…
bparrishMines Nov 8, 2023
580521a
Fix some lints, errros and call on errors
bparrishMines Nov 8, 2023
d1f305b
fix lints
bparrishMines Nov 8, 2023
a3f74be
fix tests
bparrishMines Nov 8, 2023
ed3798f
add onProceed and onCancel back
bparrishMines Nov 8, 2023
154c1f8
dont require realm to be nonnull
bparrishMines Nov 8, 2023
a0b5c4d
Merge remote-tracking branch 'upstream/main' into webview-auth-reques…
JeroenWeener Nov 14, 2023
9ac132e
Separate platform interface changes
JeroenWeener Nov 14, 2023
9df4152
Delete HttpAuthHandlerFlutterApiImpl.java
JeroenWeener Nov 14, 2023
a387bb6
Delete HttpAuthHandlerHostApiImpl.java
JeroenWeener Nov 14, 2023
1e01f79
Delete HttpAuthHandlerTest.java
JeroenWeener Nov 14, 2023
389e9ae
Delete FWFURLAuthenticationChallengeHostApiTests.m
JeroenWeener Nov 14, 2023
3e1a41b
Delete FWFURLCredentialHostApiTests.m
JeroenWeener Nov 14, 2023
bfb86aa
Delete FWFURLProtectionSpaceHostApiTests.m
JeroenWeener Nov 14, 2023
7bd194a
Delete FWFURLAuthenticationChallengeHostApi.h
JeroenWeener Nov 14, 2023
34bfa51
Delete FWFURLAuthenticationChallengeHostApi.m
JeroenWeener Nov 14, 2023
290e816
Delete FWFURLCredentialHostApi.h
JeroenWeener Nov 14, 2023
01b22d3
Delete FWFURLCredentialHostApi.m
JeroenWeener Nov 14, 2023
e1c0908
Delete FWFURLProtectionSpaceHostApi.h
JeroenWeener Nov 14, 2023
5cac2e3
Delete FWFURLProtectionSpaceHostApi.m
JeroenWeener Nov 14, 2023
5f741ff
Update packages/webview_flutter/webview_flutter_platform_interface/li…
JeroenWeener Nov 17, 2023
e8737fc
Update packages/webview_flutter/webview_flutter_platform_interface/li…
JeroenWeener Nov 17, 2023
3b0c25f
Fix typos
JeroenWeener Nov 17, 2023
06993a9
Update packages/webview_flutter/webview_flutter_platform_interface/li…
JeroenWeener Nov 17, 2023
b4f3ba2
Merge branch 'webview-auth-request-platform-interface' of https://git…
JeroenWeener Nov 17, 2023
38a0319
Revert bump to `plugin_platform_interface` version
JeroenWeener Nov 20, 2023
cc4b4e0
Merge remote-tracking branch 'upstream/main' into webview-auth-reques…
JeroenWeener Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format java files
  • Loading branch information
@JeroenWeener
JeroenWeener committed Nov 1, 2023
commit b455040622e75d0e05ef135167a9cd9504783437
13 changes: 7 additions & 6 deletions ..._android/android/src/test/java/io/flutter/plugins/webviewflutter/HttpAuthHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import static org.mockito.Mockito.verify;

import android.webkit.HttpAuthHandler;

import io.flutter.plugin.common.BinaryMessenger;
import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
Expand All @@ -17,8 +17,6 @@
import org.mockito.junit.MockitoJUnit;
import org.mockito.junit.MockitoRule;

import io.flutter.plugin.common.BinaryMessenger;

public class HttpAuthHandlerTest {
@Rule public MockitoRule mockitoRule = MockitoJUnit.rule();

Expand All @@ -40,7 +38,8 @@ public void tearDown() {

@Test
public void proceed() {
final HttpAuthHandlerHostApiImpl hostApi = new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final HttpAuthHandlerHostApiImpl hostApi =
new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final long instanceIdentifier = 65L;
final String username = "username";
final String password = "password";
Expand All @@ -53,7 +52,8 @@ public void proceed() {

@Test
public void cancel() {
final HttpAuthHandlerHostApiImpl hostApi = new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final HttpAuthHandlerHostApiImpl hostApi =
new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final long instanceIdentifier = 65L;
instanceManager.addDartCreatedInstance(mockAuthHandler, instanceIdentifier);

Expand All @@ -64,7 +64,8 @@ public void cancel() {

@Test
public void useHttpAuthUsernamePassword() {
final HttpAuthHandlerHostApiImpl hostApi = new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final HttpAuthHandlerHostApiImpl hostApi =
new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final long instanceIdentifier = 65L;
instanceManager.addDartCreatedInstance(mockAuthHandler, instanceIdentifier);

Expand Down