Skip to content

[webview_flutter] Support for handling basic authentication requests (iOS) #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 36 commits into from
Dec 19, 2023
Merged

[webview_flutter] Support for handling basic authentication requests (iOS) #5455

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
517e9d4
Implement http basic auth
JeroenWeener Aug 10, 2023
967879b
Apply feedback
JeroenWeener Aug 28, 2023
c8624c0
Create HttpAuthHandlerTest.java
JeroenWeener Aug 29, 2023
4f3574d
Format java files
JeroenWeener Aug 29, 2023
1e7f785
Regenerate build_runner files
JeroenWeener Aug 29, 2023
131bc56
Implement feedback
JeroenWeener Sep 11, 2023
bc01be4
Remove redundant key in `Info.plist`
JeroenWeener Sep 11, 2023
67aa00e
Update example apps
JeroenWeener Sep 11, 2023
32496d0
Implement http basic auth
JeroenWeener Aug 10, 2023
aeb8708
Apply feedback
JeroenWeener Aug 28, 2023
fffc4c7
Create HttpAuthHandlerTest.java
JeroenWeener Aug 29, 2023
b455040
Format java files
JeroenWeener Aug 29, 2023
2aa9bfe
Regenerate build_runner files
JeroenWeener Aug 29, 2023
db286ba
Implement feedback
JeroenWeener Sep 11, 2023
467feb3
Remove redundant key in `Info.plist`
JeroenWeener Sep 11, 2023
dad8ae6
Update example apps
JeroenWeener Sep 11, 2023
6f3d802
Merge branch 'webview-auth-request' of https://github.com/andreisas06…
JeroenWeener Nov 1, 2023
0fef591
Add platform interface dev dependency to example
JeroenWeener Nov 1, 2023
b2a4fbb
Merge branch 'main' into webview-auth-request
JeroenWeener Nov 1, 2023
ce35d9b
Update packages/webview_flutter/webview_flutter_platform_interface/li…
bparrishMines Nov 8, 2023
fc32898
Merge branch 'main' of github.com:flutter/packages into webview-auth-…
bparrishMines Nov 8, 2023
4673e65
Merge branch 'webview-auth-request' of github.com:andreisas06/package…
bparrishMines Nov 8, 2023
580521a
Fix some lints, errros and call on errors
bparrishMines Nov 8, 2023
d1f305b
fix lints
bparrishMines Nov 8, 2023
a3f74be
fix tests
bparrishMines Nov 8, 2023
ed3798f
add onProceed and onCancel back
bparrishMines Nov 8, 2023
154c1f8
dont require realm to be nonnull
bparrishMines Nov 8, 2023
3c61dbc
add line back
bparrishMines Nov 8, 2023
7cf0d7e
Merge remote-tracking branch 'upstream/main' into webview-auth-request
JeroenWeener Nov 21, 2023
a21f29a
Update changelogs
JeroenWeener Nov 21, 2023
7aca4a9
Separate ios changes
JeroenWeener Nov 21, 2023
a9e27d0
Delete packages/webview_flutter/webview_flutter_android/android/src/m…
JeroenWeener Nov 21, 2023
a42c1c4
Delete packages/webview_flutter/webview_flutter_android/android/src/m…
JeroenWeener Nov 21, 2023
e64c82f
Delete packages/webview_flutter/webview_flutter_android/android/src/t…
JeroenWeener Nov 21, 2023
3ccf157
Update pubspecs
JeroenWeener Nov 28, 2023
d0d4926
Merge branch 'webview-auth-request-ios' of https://github.com/andreis…
JeroenWeener Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format java files
  • Loading branch information
@JeroenWeener
JeroenWeener committed Oct 26, 2023
commit 4f3574d9f0444f9451e076679f818d379d44385f
13 changes: 7 additions & 6 deletions ..._android/android/src/test/java/io/flutter/plugins/webviewflutter/HttpAuthHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import static org.mockito.Mockito.verify;

import android.webkit.HttpAuthHandler;

import io.flutter.plugin.common.BinaryMessenger;
import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
Expand All @@ -17,8 +17,6 @@
import org.mockito.junit.MockitoJUnit;
import org.mockito.junit.MockitoRule;

import io.flutter.plugin.common.BinaryMessenger;

public class HttpAuthHandlerTest {
@Rule public MockitoRule mockitoRule = MockitoJUnit.rule();

Expand All @@ -40,7 +38,8 @@ public void tearDown() {

@Test
public void proceed() {
final HttpAuthHandlerHostApiImpl hostApi = new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final HttpAuthHandlerHostApiImpl hostApi =
new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final long instanceIdentifier = 65L;
final String username = "username";
final String password = "password";
Expand All @@ -53,7 +52,8 @@ public void proceed() {

@Test
public void cancel() {
final HttpAuthHandlerHostApiImpl hostApi = new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final HttpAuthHandlerHostApiImpl hostApi =
new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final long instanceIdentifier = 65L;
instanceManager.addDartCreatedInstance(mockAuthHandler, instanceIdentifier);

Expand All @@ -64,7 +64,8 @@ public void cancel() {

@Test
public void useHttpAuthUsernamePassword() {
final HttpAuthHandlerHostApiImpl hostApi = new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final HttpAuthHandlerHostApiImpl hostApi =
new HttpAuthHandlerHostApiImpl(mockBinaryMessenger, instanceManager);
final long instanceIdentifier = 65L;
instanceManager.addDartCreatedInstance(mockAuthHandler, instanceIdentifier);

Expand Down