Skip to content

[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 #5520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Nov 30, 2023
Merged

[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 #5520

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cbbe526
[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.1
kevmoo Nov 29, 2023
13202f5
lint checks
kevmoo Nov 29, 2023
4f0e3f2
oops
kevmoo Nov 30, 2023
74e6cd0
Merge remote-tracking branch 'origin/HEAD' into cross_file_web
kevmoo Nov 30, 2023
6e03569
nit
kevmoo Nov 30, 2023
ea9dc84
nit
kevmoo Nov 30, 2023
0890f25
Merge branch 'main' into cross_file_web
kevmoo Nov 30, 2023
ad4994a
Merge remote-tracking branch 'origin/HEAD' into cross_file_web
kevmoo Nov 30, 2023
8c4ad0c
nit
kevmoo Nov 30, 2023
384f649
Merge remote-tracking branch 'origin/HEAD' into cross_file_web
kevmoo Nov 30, 2023
c7ac403
more cleanup
kevmoo Nov 30, 2023
926cf94
nits
kevmoo Nov 30, 2023
6d9c663
better english
kevmoo Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@kevmoo
kevmoo committed Nov 30, 2023
commit ea9dc8499d74d141b7f7562affcddb7a5940023b
2 changes: 1 addition & 1 deletion packages/cross_file/lib/src/types/html.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ class XFile extends XFileBase {
super(path) {
if (path == null) {
_browserBlob = _createBlobFromBytes(bytes, mimeType);
// ignore: unnecessary_cast
// for pkg:web v0.3.0
// ignore: unnecessary_cast
_path = URL.createObjectURL(_browserBlob! as JSObject);
} else {
_path = path;
Expand Down
2 changes: 1 addition & 1 deletion packages/cross_file/test/x_file_html_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ final Uint8List bytes = Uint8List.fromList(utf8.encode(expectedStringContents));
final html.File textFile =
html.File(<js_util.JSAny>[bytes.toJS].toJS, 'hello.txt');
final String textFileUrl =
// ignore: unnecessary_cast
// for pkg:web v0.3.0
// ignore: unnecessary_cast
html.URL.createObjectURL(textFile as js_util.JSObject);

void main() {
Expand Down