Skip to content

[gsi_web] Do not initialize CodeClient if scopes are empty. #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Dec 2, 2023
Merged

[gsi_web] Do not initialize CodeClient if scopes are empty. #5537

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3741b64
[gsi_web] Do not initialize CodeClient if scopes are empty.
ditman Dec 1, 2023
6b82780
v 0.12.2+1
ditman Dec 1, 2023
cfcb737
Add granularity TODO.
ditman Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add granularity TODO.
  • Loading branch information
@ditman
ditman committed Dec 2, 2023
commit cfcb737d0c86704901211e4d03bab62fc4a18f53
1 change: 1 addition & 0 deletions packages/google_sign_in/google_sign_in_web/lib/src/gis_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ class GisSdkClient {
/// Requests a server auth code per:
/// https://developers.google.com/identity/oauth2/web/guides/use-code-model#initialize_a_code_client
Future<String?> requestServerAuthCode() async {
// TODO(dit): Enable granular authorization, https://github.com/flutter/flutter/issues/139406
assert(_codeClient != null,
'CodeClient not initialized correctly. Ensure the `scopes` list passed to `init()` or `initWithParams()` is not empty!');
if (_codeClient == null) {
Expand Down