Skip to content

[web_benchmarks] migrate to pkg:web #5592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Dec 7, 2023
Merged

[web_benchmarks] migrate to pkg:web #5592

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7703267
[web_benchmarks] migrate to pkg:web
kevmoo Dec 6, 2023
e92b7f1
fixes for pkg:web 0.3.0
kevmoo Dec 6, 2023
3684f60
review nit
kevmoo Dec 6, 2023
8e25e08
Update packages/web_benchmarks/lib/client.dart
kevmoo Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes for pkg:web 0.3.0
  • Loading branch information
@kevmoo
kevmoo committed Dec 6, 2023
commit e92b7f1fe8ff202c5a06549a0cf5d7ec6e4736c9
4 changes: 3 additions & 1 deletion packages/web_benchmarks/lib/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ void _printResultsToScreen(Profile profile) {
profile.scoreData.forEach((String scoreKey, Timeseries timeseries) {
body.appendHtml('<h2>$scoreKey</h2>');
body.appendHtml('<pre>${timeseries.computeStats()}</pre>');
body.append(TimeseriesVisualization(timeseries).render() as JSObject);
// TODO(kevmoo): remove `NodeClue` cast when we no longer need to support
// pkg:web 0.3.0
html.NodeGlue(body).append(TimeseriesVisualization(timeseries).render());
});
}

Expand Down