Skip to content

[two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates #5597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Dec 7, 2023
Merged

[two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates #5597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce167d4
Expose addAutomaticKeepAlives in Table delegates
Piinks Dec 7, 2023
8501b9b
Update min flutter version
Piinks Dec 7, 2023
b9355cb
Bump
Piinks Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/two_dimensional_scrollables/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 0.0.5

* Exposes addAutomaticKeepAlives in TableCellBuilderDelegate and TableCellListDelegate
* Fixes bug where having one reversed axis caused incorrect painting of a pinned row.
* Adds support for BorderRadius in TableSpanDecorations.

Expand Down
2 changes: 2 additions & 0 deletions packages/two_dimensional_scrollables/lib/src/table_view/table_delegate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ class TableCellBuilderDelegate extends TwoDimensionalChildBuilderDelegate
int pinnedColumnCount = 0,
int pinnedRowCount = 0,
super.addRepaintBoundaries,
super.addAutomaticKeepAlives,
required TableViewCellBuilder cellBuilder,
required TableSpanBuilder columnBuilder,
required TableSpanBuilder rowBuilder,
Expand Down Expand Up @@ -219,6 +220,7 @@ class TableCellListDelegate extends TwoDimensionalChildListDelegate
int pinnedColumnCount = 0,
int pinnedRowCount = 0,
super.addRepaintBoundaries,
super.addAutomaticKeepAlives,
required List<List<Widget>> cells,
required TableSpanBuilder columnBuilder,
required TableSpanBuilder rowBuilder,
Expand Down
2 changes: 1 addition & 1 deletion packages/two_dimensional_scrollables/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: two_dimensional_scrollables
description: Widgets that scroll using the two dimensional scrolling foundation.
version: 0.0.4
version: 0.0.5
repository: https://github.com/flutter/packages/tree/main/packages/two_dimensional_scrollables
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+two_dimensional_scrollables%22+

Expand Down
22 changes: 22 additions & 0 deletions packages/two_dimensional_scrollables/test/table_view/table_delegate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@ const Widget cell = SizedBox.shrink();

void main() {
group('TableCellBuilderDelegate', () {
test('exposes addAutomaticKeepAlives from super class', () {
final TableCellBuilderDelegate delegate = TableCellBuilderDelegate(
cellBuilder: (_, __) => cell,
columnBuilder: (_) => span,
rowBuilder: (_) => span,
columnCount: 5,
rowCount: 6,
addAutomaticKeepAlives: false,
);
expect(delegate.addAutomaticKeepAlives, isFalse);
});

test('asserts valid counts for rows and columns', () {
TableCellBuilderDelegate? delegate;
expect(
Expand Down Expand Up @@ -205,6 +217,16 @@ void main() {
});

group('TableCellListDelegate', () {
test('exposes addAutomaticKeepAlives from super class', () {
final TableCellListDelegate delegate = TableCellListDelegate(
cells: <List<Widget>>[<Widget>[]],
columnBuilder: (_) => span,
rowBuilder: (_) => span,
addAutomaticKeepAlives: false,
);
expect(delegate.addAutomaticKeepAlives, isFalse);
});

test('asserts valid counts for rows and columns', () {
TableCellListDelegate? delegate;
expect(
Expand Down