Skip to content

[web_benchmarks] Add support for analyzing benchmark results #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 15 commits into from
Dec 12, 2023
Merged

[web_benchmarks] Add support for analyzing benchmark results #5630

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
843bb63
Add support for analyzing benchmark results
kenzieschmoll Dec 8, 2023
d91711a
remove import
kenzieschmoll Dec 8, 2023
4d8073e
use code-excerpt
kenzieschmoll Dec 8, 2023
b614de0
add new line
kenzieschmoll Dec 8, 2023
0c6f947
review comments
kenzieschmoll Dec 11, 2023
8110834
formatting
kenzieschmoll Dec 11, 2023
26ce911
fix readme
kenzieschmoll Dec 11, 2023
bbaba5b
review comments
kenzieschmoll Dec 11, 2023
e6e5f06
fixes
kenzieschmoll Dec 11, 2023
5bbfaa8
don't serialize
kenzieschmoll Dec 11, 2023
511b1e7
shorten
kenzieschmoll Dec 11, 2023
3a8f2ea
shorten further
kenzieschmoll Dec 11, 2023
bb85842
shorten
kenzieschmoll Dec 11, 2023
43fd824
stop serializing in sumwith
kenzieschmoll Dec 11, 2023
04f7b64
Merge branch 'main' into analysis
kenzieschmoll Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
shorten
  • Loading branch information
@kenzieschmoll
kenzieschmoll committed Dec 11, 2023
commit bb858421eb779b07d7b0e8bb79087abf28f86b9f
10 changes: 1 addition & 9 deletions packages/web_benchmarks/lib/analysis.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,9 @@ BenchmarkResults computeDelta(
for (final String benchmarkName in test.scores.keys) {
final List<BenchmarkScore> testScores = test.scores[benchmarkName]!;
final List<BenchmarkScore>? baselineScores = baseline.scores[benchmarkName];
if (baselineScores == null) {
delta[benchmarkName] = List<BenchmarkScore>.generate(
testScores.length,
(int i) => testScores[i]._copyWith(),
);
continue;
}

delta[benchmarkName] = testScores.map<BenchmarkScore>(
(BenchmarkScore testScore) {
final BenchmarkScore? baselineScore = baselineScores.firstWhereOrNull(
final BenchmarkScore? baselineScore = baselineScores?.firstWhereOrNull(
(BenchmarkScore s) => s.metric == testScore.metric);
return testScore._copyWith(
delta: baselineScore == null
Expand Down