Skip to content

[image_picker] Remove input element after completion #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Jan 5, 2024
Merged

[image_picker] Remove input element after completion #5654

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e44ce6
Remove input element after completion
Amir-P Dec 12, 2023
9947d0c
Format
Amir-P Dec 12, 2023
7b54486
Update CHANGELOG and version
Amir-P Dec 12, 2023
9a0fcd6
Update AUTHORS
Amir-P Dec 12, 2023
1cd98cb
Simplify
Amir-P Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify
  • Loading branch information
@Amir-P
Amir-P committed Dec 14, 2023
commit 1cd98cb005e255da54584b8bd06ca79c863a7ebe
5 changes: 1 addition & 4 deletions packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class ImagePickerPlugin extends ImagePickerPlatform {
) as html.FileUploadInputElement;
_injectAndActivate(input);

return _getSelectedXFiles(input).whenComplete(() => _remove(input));
return _getSelectedXFiles(input).whenComplete(input.remove);
}

// Deprecated methods follow...
Expand Down Expand Up @@ -320,9 +320,6 @@ class ImagePickerPlugin extends ImagePickerPlatform {
// TODO(dit): Reimplement this with the showPicker() API, https://github.com/flutter/flutter/issues/130365
element.click();
}

/// Removes the file input element
void _remove(html.Element element) => _target.children.clear();
}

// Some tools to override behavior for unit-testing
Expand Down