Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
743b38d
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
4427ac6
Undo changes
camsim99 May 10, 2023
3f9cf35
Start wrapping
camsim99 Nov 27, 2023
c37e8cd
Progress, left todo as marker
camsim99 Dec 13, 2023
ad9c29c
More wrapping, start with meteringpoint
camsim99 Dec 13, 2023
8472b7c
Wrapping
camsim99 Dec 26, 2023
886706b
New files
camsim99 Dec 27, 2023
51da157
Finish non cam2 wrpaping
camsim99 Jan 2, 2024
d157b46
Adding tests + docs
camsim99 Jan 3, 2024
4a0872c
More wrapping and tests
camsim99 Jan 4, 2024
aa0f947
More wrapping, tests
camsim99 Jan 5, 2024
05b784d
Final inital wrapping
camsim99 Jan 5, 2024
36257d4
java formatting + fix dart tests
camsim99 Jan 5, 2024
a9af98d
Fix Java classes
camsim99 Jan 8, 2024
4af2266
Get tests running
camsim99 Jan 8, 2024
fb7927b
Fix java tests
camsim99 Jan 8, 2024
b5e974c
Bump version
camsim99 Jan 8, 2024
ba95c41
Self review
camsim99 Jan 9, 2024
c435903
Merge remote-tracking branch 'upstream/main' into camx_cc
camsim99 Jan 9, 2024
be193db
Merge branch 'main' into camx_cc
camsim99 Jan 9, 2024
2e69a9c
Nits
camsim99 Jan 9, 2024
cc4ecee
Merge remote-tracking branch 'refs/remotes/origin/camx_cc' into camx_cc
camsim99 Jan 9, 2024
643fabb
lint
camsim99 Jan 9, 2024
36d9a2e
Update packages/camera/camera_android_camerax/pigeons/camerax_library…
camsim99 Jan 24, 2024
92157c4
Update packages/camera/camera_android_camerax/android/src/test/java/i…
camsim99 Jan 24, 2024
9977463
Update packages/camera/camera_android_camerax/lib/src/camera_control.…
camsim99 Jan 24, 2024
469d0cd
Merge remote-tracking branch 'upstream/main' into camx_cc
camsim99 Jan 24, 2024
cdfd98c
format
camsim99 Jan 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More wrapping, start with meteringpoint
  • Loading branch information
camsim99 committed Jan 2, 2024
commit ad9c29c88b05c41861e3b3ba14394ee556e891dd
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,10 @@ public FocusMeteringActionFlutterApiWrapper(
*/
public void create(
@NonNull FocusMeteringAction instance,
@NonNull Long meteringPointIdArg,
@Nullable Long meteringModeArg,
@NonNull Reply<Void> callback) {
if (!instanceManager.containsInstance(instance)) {
focusMeteringActionFlutterApi.create(
instanceManager.addHostCreatedInstance(instance), code, callback);
instanceManager.addHostCreatedInstance(instance), callback);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ Long addPoint(@NonNull Long identifier, @NonNull Long meteringPointId, @Nullable
final FocusMeteringActionFlutterApiImpl flutterApi =
new FocusMeteringActionFlutterApiImpl(binaryMessenger, instanceManager);
flutterApi.create(newFocusMeteringAction, reply -> {});
return instanceManager.getIdentifierForStrongReference(newFocusMeteringAction); // TODO(camsim99): I'm here! Need to figure out how to handle list of metering points. Thinking use getter.
return instanceManager.getIdentifierForStrongReference(newFocusMeteringAction);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ class FocusMeteringAction extends JavaObject {
FocusMeteringAction({
BinaryMessenger? binaryMessenger,
InstanceManager? instanceManager,
required this.meteringPoint,
required this.meteringMode,
required MeteringPoint meteringPoint,
int? meteringMode,
}) : super.detached(
binaryMessenger: binaryMessenger,
instanceManager: instanceManager,
Expand All @@ -34,8 +34,6 @@ class FocusMeteringAction extends JavaObject {
FocusMeteringAction.detached({
BinaryMessenger? binaryMessenger,
InstanceManager? instanceManager,
required this.meteringPoint,
required this.meteringMode,
}) : super.detached(
binaryMessenger: binaryMessenger,
instanceManager: instanceManager,
Expand All @@ -46,12 +44,6 @@ class FocusMeteringAction extends JavaObject {

late final _FocusMeteringActionHostApiImpl _api;

/// something
final MeteringPoint meteringPoint;

/// something
final int? meteringMode;

/// Flag for metering mode that indicates the AF (Auto Focus) region is
/// enabled.
///
Expand All @@ -75,7 +67,7 @@ class FocusMeteringAction extends JavaObject {

/// Host API implementation of [FocusMeteringAction].
class _FocusMeteringActionHostApiImpl extends FocusMeteringActionHostApi {
/// Constructs a [FocusMeteringActionHostApiImpl].
/// Constructs a [_FocusMeteringActionHostApiImpl].
///
/// If [binaryMessenger] is null, the default [BinaryMessenger] will be used,
/// which routes to the host platform.
Expand Down Expand Up @@ -104,10 +96,7 @@ class _FocusMeteringActionHostApiImpl extends FocusMeteringActionHostApi {
final int identifier = instanceManager.addDartCreatedInstance(instance,
onCopy: (FocusMeteringAction original) {
return FocusMeteringAction.detached(
binaryMessenger: binaryMessenger,
instanceManager: instanceManager,
meteringPoint: meteringPoint,
meteringMode: meteringMode);
binaryMessenger: binaryMessenger, instanceManager: instanceManager);
});
create(identifier, instanceManager.getIdentifier(meteringPoint)!,
meteringMode);
Expand Down Expand Up @@ -150,21 +139,15 @@ class FocusMeteringActionFlutterApiImpl extends FocusMeteringActionFlutterApi {
final InstanceManager _instanceManager;

@override
void create(int identifier, int meteringPointId, int? meteringMode) {
void create(int identifier) {
_instanceManager.addHostCreatedInstance(
FocusMeteringAction.detached(
binaryMessenger: _binaryMessenger,
instanceManager: _instanceManager,
meteringPoint: _instanceManager
.getInstanceWithWeakReference<MeteringPoint>(meteringPointId),
meteringMode: meteringMode),
binaryMessenger: _binaryMessenger, instanceManager: _instanceManager),
identifier,
onCopy: (FocusMeteringAction original) {
return FocusMeteringAction.detached(
binaryMessenger: _binaryMessenger,
instanceManager: _instanceManager,
meteringMode: original.meteringMode,
meteringPoint: original.meteringPoint,
);
},
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'package:flutter/services.dart' show BinaryMessenger;
import 'package:meta/meta.dart' show immutable;

// TODO: add new flutter apis
// TODO(camsim99): add new flutter apis
import 'android_camera_camerax_flutter_api_impls.dart';
import 'camerax_library.g.dart';
import 'instance_manager.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,23 @@ import 'java_object.dart';
/// somethin
@immutable
class MeteringPoint extends JavaObject {
/// Creates a [MeteringPoint].
MeteringPoint({
BinaryMessenger? binaryMessenger,
InstanceManager? instanceManager,
required double x,
required double y,
required double? size,
}) : super.detached(
binaryMessenger: binaryMessenger,
instanceManager: instanceManager,
) {
_api = _MeteringPointHostApiImpl(
binaryMessenger: binaryMessenger, instanceManager: instanceManager);
_api.createFromInstance(this, x, y, size);
AndroidCameraXCameraFlutterApis.instance.ensureSetUp();
}

/// Creates a [MeteringPoint] that is not automatically attached to a
/// native object.
MeteringPoint.detached({
Expand All @@ -29,8 +46,11 @@ class MeteringPoint extends JavaObject {

late final _MeteringPointHostApiImpl _api;

/// something
Future<double> getDefaultPointSize() => _api.getDefaultPointSize();

/// somethin
Future<int> getSize() => _api.getSizeFromInstance(this);
Future<double> getSize() => _api.getSizeFromInstance(this);
}

/// Host API implementation of [MeteringPoint].
Expand Down Expand Up @@ -58,7 +78,7 @@ class _MeteringPointHostApiImpl extends MeteringPointHostApi {
late final InstanceManager instanceManager;

/// somethin
Future<int> getSizeFromInstance(MeteringPoint instance) {
Future<double> getSizeFromInstance(MeteringPoint instance) {
final int identifier = instanceManager.getIdentifier(instance)!;
return getSize(identifier);
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ abstract class FocusMeteringActionHostApi {

@FlutterApi()
abstract class FocusMeteringActionFlutterApi {
void create(int identifier, int meteringPointId, int? meteringMode);
void create(int identifier);
}

@HostApi()
Expand All @@ -484,12 +484,11 @@ abstract class FocusMeteringResultFlutterApi {

@HostApi(dartHostTestHandler: 'TestMeteringPointHostApi')
abstract class MeteringPointHostApi {
int getSize(int identifier);
}
void create(int identifier, double x, double y, double? size);

@FlutterApi()
abstract class MeteringPointFlutterApi {
void create(int identifier);
double getDefaultPointSize();

double getSize(int identifier);
}

@HostApi(dartHostTestHandler: 'TestDisplayOrientedMeteringPointFactoryHostApi')
Expand Down