Skip to content

[google_maps_flutter] Implement polyline patterns in google maps ios #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 48 commits into from
May 28, 2024
Merged

[google_maps_flutter] Implement polyline patterns in google maps ios #5757

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
9af4bad
Implement polyline in google maps ios
Hari-07 Dec 26, 2023
b6c0d6a
Updated changelog
Hari-07 Dec 26, 2023
5652138
Add . to changelog
Hari-07 Dec 26, 2023
3b3f7ac
Implement tests
Hari-07 Jan 4, 2024
8729818
Fix formatting in test files
Hari-07 Jan 4, 2024
a4fdeaa
Add license text
Hari-07 Jan 4, 2024
d184edd
Revert merge changelog mess
Hari-07 Jan 4, 2024
5859fd2
Run update-release-info
Hari-07 Jan 4, 2024
1a314d8
Use floating point value for length
Hari-07 Jan 25, 2024
98669dd
Comment explaining cannot use isequal
Hari-07 Jan 25, 2024
00ea572
Add new test file to xcode project
Hari-07 Feb 2, 2024
937a030
Add period to comment
Hari-07 Feb 2, 2024
91439c5
Set version in pubspec
Hari-07 Feb 2, 2024
ef1d1a6
Make the polyline controller test stateless
Hari-07 Feb 2, 2024
5c6a694
Remove empty line
Hari-07 Feb 2, 2024
cb7b9ea
Dont make polyline controller public
Hari-07 Feb 2, 2024
762741e
add comments and avoid making get path public
Hari-07 Feb 2, 2024
90537da
Fix test
Hari-07 Feb 3, 2024
76b3d59
Add stroke style json conversion test
Hari-07 Feb 3, 2024
c10082c
Fix formatting issue in new test
Hari-07 Feb 3, 2024
28a7840
Format comment
Hari-07 Feb 3, 2024
41e4a2c
Update changelog
Hari-07 Mar 24, 2024
ef19218
Remove android changelog comment
Hari-07 Mar 24, 2024
25e003e
Fix some of the comments
Hari-07 Mar 24, 2024
6d7f7c1
Use helper function to extract nullable field from dict
Hari-07 Mar 25, 2024
2a58ab9
Revert path for polyline into static function
Hari-07 Mar 25, 2024
8428c96
Specify the type more
Hari-07 Apr 28, 2024
4eca5a6
Remove on ios in changelog
Hari-07 May 8, 2024
3975be2
Move the header file
Hari-07 May 11, 2024
0daeda6
Remove test temporarily
Hari-07 May 11, 2024
a1daf7a
Merge branch 'main' of github.com:flutter/packages into polyline-patt…
Hari-07 May 11, 2024
3506885
Add back tests
Hari-07 May 11, 2024
64006eb
Add back changelog change
Hari-07 May 11, 2024
9649254
Bump pubspec version
Hari-07 May 11, 2024
4b3ddad
Add polyline test file to xcode
Hari-07 May 11, 2024
e605cb4
Fix comment style and use fast iteration
Hari-07 May 25, 2024
c984efb
Fix some formatting
Hari-07 May 25, 2024
c5f2bb3
Rename and cleanup
Hari-07 May 25, 2024
9d8bdcd
Comment on test method
Hari-07 May 25, 2024
2e31f57
Make getvalue or nil static
Hari-07 May 25, 2024
3d2a257
Run format tool again
Hari-07 May 25, 2024
f91bf90
Merge branch 'main' of github.com:flutter/packages into polyline-patt…
Hari-07 May 25, 2024
01b1b62
Stop using deprecated method
Hari-07 May 25, 2024
7e8d346
Add some more missing types
Hari-07 May 28, 2024
3d83dad
Fix formatting issue
Hari-07 May 28, 2024
a6abf68
Remove extra line around comments
Hari-07 May 28, 2024
26aba97
Make test header public
Hari-07 May 28, 2024
cf68784
Merge branch 'main' of github.com:flutter/packages into polyline-patt…
Hari-07 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some more missing types
  • Loading branch information
@Hari-07
Hari-07 committed May 28, 2024
commit 7e8d346c2021a3637bfefb50c09c98f393a0f56e
2 changes: 1 addition & 1 deletion ...ps_flutter_ios/example/ios14/ios/RunnerTests/FLTGoogleMapJSONConversionsConversionTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ - (void)testCameraUpdateFromChannelValueZoomTo {
}

- (void)testLengthsFromPatterns {
NSArray *patterns = @[ @[ @"gap", @10 ], @[ @"dash", @6.4 ] ];
NSArray<NSArray<id> *> *patterns = @[ @[ @"gap", @10 ], @[ @"dash", @6.4 ] ];

NSArray<NSNumber *> *spanLengths = [FLTGoogleMapJSONConversions spanLengthsFromPatterns:patterns];

Expand Down
4 changes: 2 additions & 2 deletions ...oogle_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsPolylinesControllerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ @implementation GoogleMapsPolylinesControllerTests
/// @return An object of FLTGoogleMapPolylineController
///
- (FLTGoogleMapPolylineController *)polylineControllerWithMockedMap {
NSDictionary *polyline = @{
NSDictionary<NSString*, id> *polyline = @{
@"points" : @[
@[ @(52.4816), @(-3.1791) ], @[ @(54.043), @(-2.9925) ], @[ @(54.1396), @(-4.2739) ],
@[ @(53.4153), @(-4.0829) ]
Expand Down Expand Up @@ -68,7 +68,7 @@ - (void)testSetPatterns {
}

- (void)testStrokeStylesFromPatterns {
NSArray *patterns = @[ @[ @"gap", @10 ], @[ @"dash", @10 ] ];
NSArray<NSArray<id> *> *patterns = @[ @[ @"gap", @10 ], @[ @"dash", @10 ] ];
UIColor *strokeColor = [UIColor redColor];

NSArray<GMSStrokeStyle *> *patternStrokeStyle =
Expand Down