-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[url_launcher] Add InAppBrowserConfiguration parameter
#5758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 35 commits into
flutter:main
from
Alex-Usmanov:show-title-platform-interface
Jan 4, 2024
Merged
Changes from 29 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
e41ea0e
add android show title customization functionality
Alex-Usmanov fb67692
Pass the parameter
Alex-Usmanov 21cd06f
Dependency overrides
Alex-Usmanov 276c08b
Add tests for native side
Alex-Usmanov 1897451
Cover dart side with tests
Alex-Usmanov 5cd1709
Format
Alex-Usmanov bc943c5
Reduce code repetition
Alex-Usmanov d6306ba
Revert todo change
Alex-Usmanov f59475b
Wrap browser customization values in another configuration object
Alex-Usmanov 157343b
Remove deps overrides
Alex-Usmanov ae20b08
Revert more deps overrides
Alex-Usmanov 214b0a9
Revert web as well
Alex-Usmanov cd7dfc9
Revert go_router
Alex-Usmanov d205c7c
Merge branch 'main' into main
Alex-Usmanov 5eef662
Merge remote-tracking branch 'upstream/main'
Alex-Usmanov c86ff6e
Format files
Alex-Usmanov 92b2197
Fix tests
Alex-Usmanov 425617e
Add browseroptions to launchUrlString & add more tests
Alex-Usmanov ece2b78
Fix docstrings
Alex-Usmanov 3ddd644
Revert test format change
Alex-Usmanov cd361d0
Fix tests
Alex-Usmanov f0017b7
Version bumps and changelogs
Alex-Usmanov 6105671
Merge remote-tracking branch 'upstream/main'
Alex-Usmanov a50be0f
Return path-based dependencies
Alex-Usmanov ef9c154
Add licences
Alex-Usmanov f4b08cb
Merge remote-tracking branch 'upstream/main'
Alex-Usmanov 80d439b
Fix documentation & changelog
Alex-Usmanov 992d38e
Merge remote-tracking branch 'upstream/main'
Alex-Usmanov 6973c07
Revert everything except for url_launcher_platform_interface
Alex-Usmanov 193c076
Add backticks to SFSafariViewController in platform interface changelog
Alex-Usmanov b399c9b
Merge remote-tracking branch 'upstream/main'
Alex-Usmanov 1ad83a2
More merging
Alex-Usmanov c36e5ff
Merge branch 'main' into show-title-platform-interface
Alex-Usmanov b24e139
Fix version
Alex-Usmanov eab1467
Revert android changes
Alex-Usmanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 4 additions & 1 deletion
5
packages/url_launcher/url_launcher_platform_interface/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
.../url_launcher/url_launcher_platform_interface/test/in_app_browser_configuration_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart'; | ||
|
|
||
| void main() { | ||
| test('InAppBrowserConfiguration defaults to showTitle false', () { | ||
| expect(const InAppBrowserConfiguration().showTitle, false); | ||
| }); | ||
|
|
||
| test('InAppBrowserConfiguration showTitle can be set to true', () { | ||
| expect(const InAppBrowserConfiguration(showTitle: true).showTitle, true); | ||
| }); | ||
| } |
28 changes: 28 additions & 0 deletions
28
packages/url_launcher/url_launcher_platform_interface/test/launch_options_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart'; | ||
|
|
||
| void main() { | ||
| test('LaunchOptions have default InAppBrowserConfiguration when not passed', | ||
| () { | ||
| expect( | ||
| const LaunchOptions().browserConfiguration, | ||
| const InAppBrowserConfiguration(), | ||
| ); | ||
| }); | ||
|
|
||
| test('passing non-default InAppBrowserConfiguration to LaunchOptions works', | ||
| () { | ||
| const InAppBrowserConfiguration browserConfiguration = | ||
| InAppBrowserConfiguration(showTitle: true); | ||
|
|
||
| const LaunchOptions launchOptions = LaunchOptions( | ||
| browserConfiguration: browserConfiguration, | ||
| ); | ||
|
|
||
| expect(launchOptions.browserConfiguration, browserConfiguration); | ||
| }); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
`SFSafariViewController`