Skip to content

[webview_flutter_wkwebview] Add javascript panel interface for wkwebview #5795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jan 18, 2024
Merged

[webview_flutter_wkwebview] Add javascript panel interface for wkwebview #5795

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1923b69
Add javascript panel interface for wkwebview
jsharp83 Jan 4, 2024
aebf948
remove dynamic type result
jsharp83 Jan 17, 2024
d062b10
remove unnecessary completionHandler definitions
jsharp83 Jan 17, 2024
f7ea3a1
formatting
bparrishMines Jan 18, 2024
4222646
tests
bparrishMines Jan 18, 2024
c480a66
change nil check
jsharp83 Jan 18, 2024
714a0eb
Merge branch 'main' of github.com:flutter/packages into add-javascrip…
bparrishMines Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change nil check
  • Loading branch information
@jsharp83
jsharp83 committed Jan 18, 2024
commit c480a66f50c3a8b27ce7077426a02dd3bf3a0747
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFDataConverters.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ WKAudiovisualMediaTypes FWFNativeWKAudiovisualMediaTypeFromEnumData(

FWFNSUrlRequestData *FWFNSUrlRequestDataFromNativeNSURLRequest(NSURLRequest *request) {
return [FWFNSUrlRequestData
makeWithUrl:request.URL.absoluteString.length > 0 ? request.URL.absoluteString : @""
makeWithUrl:request.URL.absoluteString == nil ? @"" : request.URL.absoluteString
httpMethod:request.HTTPMethod
httpBody:request.HTTPBody
? [FlutterStandardTypedData typedDataWithBytes:request.HTTPBody]
Expand Down