Skip to content

[rfw] Add OverflowBar widget and Update ButtonBar widget implementation #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Jan 30, 2024
Merged

[rfw] Add OverflowBar widget and Update ButtonBar widget implementation #5807

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f223c8
[rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implemen…
TahaTesser Jan 29, 2024
b555ba9
Update docs
TahaTesser Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update docs
  • Loading branch information
@TahaTesser
TahaTesser committed Jan 30, 2024
commit b555ba995fd380b9793cbf8d7604c06bc0579846
20 changes: 10 additions & 10 deletions packages/rfw/lib/src/flutter/material_widgets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,21 @@ import 'runtime.dart';
/// * [VisualDensity] is represented in the manner described in the documentation
/// of the [ArgumentDecoders.visualDensity] method.
///
/// Some features have changed in the underlying Material library and are
/// Some features have changed in the underlying Flutter's material library and are
/// therefore no longer supported, including:
///
/// * The ButtonBar widget in package:flutter/material.dart is planned to be
/// deprecated in favor of the OverflowBar widget. The ButtonBar widget in
/// rfw package uses the OverflowBar widget internally for backward compatibility.
/// The ButtonBar widget in rfw package is not deprecated and will continue to
/// be supported. As a result, the following ButtonBar parameters are no longer
/// * The [ButtonBar] widget in the Flutter's material library is planned to be
/// deprecated in favor of the [OverflowBar] widget. The [ButtonBar] widget in
/// `rfw` package uses the [OverflowBar] widget internally for backward compatibility.
/// The [ButtonBar] widget in `rfw` package is not deprecated and will continue to
/// be supported. As a result, the following [ButtonBar] parameters are no longer
/// supported:
///
/// * buttonMinWidth
/// * buttonHeight
/// * buttonAlignedDropdown
/// * `buttonMinWidth`
/// * `buttonHeight`
/// * `buttonAlignedDropdown`
///
/// It is recommended to use the OverflowBar widget.
/// It is recommended to use the [OverflowBar] widget.
///
Copy link
Contributor

@Hixie Hixie Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all needs to be markdown with hyperlinks and so on (sorry if i wasn't clear in the earlier comment).

What I mean is e.g. ButtonBar needs to be [ButtonBar], package:flutter/material.dart needs to be whatever the magic incantation is to reference the material library (maybe just [material]?), rfw needs to either be in backticks or uppercase, the parameters in the list should be in backticks, etc.

Copy link
Member Author

@TahaTesser TahaTesser Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh my bad. Thanks for the suggestion!

package:flutter/material.dart can be simply referenced as "Flutter's material library". We reference like this in the framework too in various classes

/// Some features are not supported:
///
Expand Down