Skip to content

[webview_flutter_wkebview] Verify JavaScriptChannels have a unique name #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jan 17, 2024
Merged

[webview_flutter_wkebview] Verify JavaScriptChannels have a unique name #5904

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9bf125
verify unique name
bparrishMines Jan 16, 2024
8018c61
improve error message
bparrishMines Jan 17, 2024
6e9260c
Merge branch 'main' of github.com:flutter/packages into webkit_unique…
bparrishMines Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve error message
  • Loading branch information
@bparrishMines
bparrishMines committed Jan 17, 2024
commit 8018c6170e616368dd63f93faf636a4904d62c03
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ class WebKitWebViewController extends PlatformWebViewController {
final String channelName = javaScriptChannelParams.name;
Copy link
Member

@jmagman jmagman Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is somewhere already checking this isn't an empty string?

This parameter must be unique within the user content controller and must not be an empty string.

https://developer.apple.com/documentation/webkit/wkusercontentcontroller/1537172-addscriptmessagehandler

Copy link
Contributor Author

@bparrishMines bparrishMines Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it checks it here with an assert: https://github.com/flutter/packages/blob/main/packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart#L695

if (_javaScriptChannelParams.containsKey(channelName)) {
throw ArgumentError(
'A JavaScriptChannel with name `$channelName` has already been added.',
'A JavaScriptChannel with name `$channelName` already exists.',
);
}

Expand Down