Skip to content

[ci] Add flags to formatter command to decide which formatters to run #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Jan 18, 2024
Merged

[ci] Add flags to formatter command to decide which formatters to run #5905

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64cf5a5
[ci] Add flags to formatter command to decide which formatters to run
jmagman Jan 16, 2024
ca0792d
remove platform check
jmagman Jan 16, 2024
e937de9
flag tests
jmagman Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
flag tests
  • Loading branch information
@jmagman
jmagman committed Jan 17, 2024
commit e937de9845f7c8b2a95f7d0a6f110b4a0dd64abe
44 changes: 42 additions & 2 deletions script/tool/test/format_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,16 @@ void main() {
]));
});

test('skips dart if --no-dart flag is provided', () async {
const List<String> files = <String>[
'lib/a.dart',
];
createFakePlugin('a_plugin', packagesDir, extraFiles: files);

await runCapturingPrint(runner, <String>['format', '--no-dart']);
expect(processRunner.recordedCalls, orderedEquals(<ProcessCall>[]));
});

test('formats .java files', () async {
const List<String> files = <String>[
'android/src/main/java/io/flutter/plugins/a_plugin/a.java',
Expand Down Expand Up @@ -250,7 +260,7 @@ void main() {
]));
});

test('honors --java flag', () async {
test('honors --java-path flag', () async {
const List<String> files = <String>[
'android/src/main/java/io/flutter/plugins/a_plugin/a.java',
'android/src/main/java/io/flutter/plugins/a_plugin/b.java',
Expand Down Expand Up @@ -280,6 +290,16 @@ void main() {
]));
});

test('skips Java if --no-java flag is provided', () async {
const List<String> files = <String>[
'android/src/main/java/io/flutter/plugins/a_plugin/a.java',
];
createFakePlugin('a_plugin', packagesDir, extraFiles: files);

await runCapturingPrint(runner, <String>['format', '--no-java']);
expect(processRunner.recordedCalls, orderedEquals(<ProcessCall>[]));
});

test('formats c-ish files', () async {
const List<String> files = <String>[
'ios/Classes/Foo.h',
Expand Down Expand Up @@ -377,7 +397,7 @@ void main() {
]));
});

test('honors --clang-format flag', () async {
test('honors --clang-format-path flag', () async {
const List<String> files = <String>[
'windows/foo_plugin.cpp',
];
Expand Down Expand Up @@ -434,6 +454,16 @@ void main() {
]));
});

test('skips clang-format if --no-clang-format flag is provided', () async {
const List<String> files = <String>[
'linux/foo_plugin.cc',
];
createFakePlugin('a_plugin', packagesDir, extraFiles: files);

await runCapturingPrint(runner, <String>['format', '--no-clang-format']);
expect(processRunner.recordedCalls, orderedEquals(<ProcessCall>[]));
});

group('kotlin-format', () {
test('formats .kt files', () async {
const List<String> files = <String>[
Expand Down Expand Up @@ -488,6 +518,16 @@ void main() {
contains('Failed to format Kotlin files: exit code 1.'),
]));
});

test('skips Kotlin if --no-kotlin flag is provided', () async {
const List<String> files = <String>[
'android/src/main/kotlin/io/flutter/plugins/a_plugin/a.kt',
];
createFakePlugin('a_plugin', packagesDir, extraFiles: files);

await runCapturingPrint(runner, <String>['format', '--no-kotlin']);
expect(processRunner.recordedCalls, orderedEquals(<ProcessCall>[]));
});
});

group('swift-format', () {
Expand Down