Skip to content

[rfw] Add support for widget builders #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 22 commits into from
Mar 6, 2024
Merged

[rfw] Add support for widget builders #5907

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
93d0553
Add support for widget builders.
tugorez Feb 17, 2024
167861c
Apply reviewers feedback
tugorez Feb 27, 2024
f42e136
Apply reviewers feedback
tugorez Feb 27, 2024
0447cc3
Do not infer required values
tugorez Feb 27, 2024
1ef16c4
Apply reviewers feedback
tugorez Feb 27, 2024
e932304
Fix tests
tugorez Feb 27, 2024
cefb096
Apply reviewers feedback
tugorez Feb 27, 2024
8ed0a43
Supports events
tugorez Feb 28, 2024
09cc332
Fix docs
tugorez Feb 28, 2024
4ff5572
Fix docs
tugorez Feb 28, 2024
6911f90
Remove trailing spaces
tugorez Feb 28, 2024
b2aad12
Fixes docs
tugorez Feb 28, 2024
2d3b120
Add version changes
tugorez Feb 28, 2024
6584379
Fix analyzer issues
tugorez Feb 28, 2024
939a149
Fix typo
tugorez Mar 5, 2024
95158b9
Apply grammar suggestions
tugorez Mar 5, 2024
a4934ff
update tests
tugorez Mar 6, 2024
c24389b
Fix switch
tugorez Mar 6, 2024
7cab0f2
Increase binary coverage
tugorez Mar 6, 2024
41db095
Improve runtime coverage
tugorez Mar 6, 2024
d0f2f3a
Remove unused code
tugorez Mar 6, 2024
93b6ac1
Make the analyzer happy and loved
tugorez Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@tugorez
tugorez committed Mar 6, 2024
commit 939a14907eaea55cd4366b0af2d79e1b4a3731cb
18 changes: 9 additions & 9 deletions packages/rfw/test/runtime_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ void main() {
late DynamicContent data;
late List<RfwEvent> dispatchedEvents;

Widget rwfWidget(String library, {Map<String, Object?>? initialData}) {
Widget rfwWidget(String library, {Map<String, Object?>? initialData}) {
const LibraryName coreLibraryName = LibraryName(<String>['core']);
const LibraryName localLibraryName = LibraryName(<String>['local']);
const LibraryName remoteLibraryName = LibraryName(<String>['remote']);
Expand Down Expand Up @@ -1148,7 +1148,7 @@ void main() {
}

testWidgets('Widget builders - work when scope is not used', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand All @@ -1164,7 +1164,7 @@ void main() {
});

testWidgets('Widget builders - work when scope is used', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand All @@ -1183,7 +1183,7 @@ void main() {
});

testWidgets('Widget builders - work with state', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand Down Expand Up @@ -1213,7 +1213,7 @@ void main() {
});

testWidgets('Widget builders - work with data', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand Down Expand Up @@ -1262,7 +1262,7 @@ void main() {
});

testWidgets('Widget builders - work with events', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand All @@ -1287,7 +1287,7 @@ void main() {
});

testWidgets('Widget builders - works nested', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand Down Expand Up @@ -1321,7 +1321,7 @@ void main() {
});

testWidgets('Widget builders - switch works with builder', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand All @@ -1342,7 +1342,7 @@ void main() {
});

testWidgets('Widget builders - builder works with switch', (WidgetTester tester) async {
final Widget widget = rwfWidget('''
final Widget widget = rfwWidget('''
import core;
import local;

Expand Down