Skip to content

[pigeon] Support other hosts in generated file CI checks #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 16 commits into from
Jan 20, 2024
+1,424 −556
Merged

[pigeon] Support other hosts in generated file CI checks #5944

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bb14fc7
Temp hack for local testing
stuartmorgan-g Jan 19, 2024
cb16cfd
Include swift for testing
stuartmorgan-g Jan 19, 2024
f2ad42a
Add explicit language selection for formatting
stuartmorgan-g Jan 19, 2024
3872d99
Per-platform language split
stuartmorgan-g Jan 19, 2024
cbdf3e9
Fully wire up
stuartmorgan-g Jan 19, 2024
28c2e4a
Disable for now
stuartmorgan-g Jan 19, 2024
262da18
Remove local hack
stuartmorgan-g Jan 19, 2024
b501fc7
Enable Swift check
stuartmorgan-g Jan 20, 2024
8d6bcb3
Merge branch 'main' into pigeon-format-check
stuartmorgan-g Jan 20, 2024
e136357
Remove unconditional --no-swift
stuartmorgan-g Jan 20, 2024
aa1158a
Add .h for ObjC
stuartmorgan-g Jan 20, 2024
ae2c565
Merge remote-tracking branch 'upstream/main' into pigeon-format-check
stuartmorgan-g Jan 20, 2024
c505762
Remove generated code filter from Swift formatting
stuartmorgan-g Jan 20, 2024
f875c84
Autoformat generated output
stuartmorgan-g Jan 20, 2024
afaaf0d
Autoformat quick_actions
stuartmorgan-g Jan 20, 2024
ecce48d
Merge remote-tracking branch 'upstream/main' into pigeon-format-check
stuartmorgan-g Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include swift for testing
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jan 19, 2024
commit cb16cfd3718fba2381302fdb37f2f3163adeee4f
1 change: 1 addition & 0 deletions packages/pigeon/tool/shared/generation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ Future<int> formatAllFiles({required String repositoryRoot}) {
'run',
'script/tool/bin/flutter_plugin_tools.dart',
'format',
'--swift',
'--packages=pigeon',
],
workingDirectory: repositoryRoot,
Expand Down