-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[pigeon] Adds Dart implementation of ProxyApi #6043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 45 commits into
flutter:main
from
bparrishMines:pigeon_wrapper_dart_2
Mar 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
6e385f1
update ast
bparrishMines abc026a
constructor extend method and make required default to true
bparrishMines 870cec3
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 0c69e1d
use helper method
bparrishMines eb14522
fix some validation and add tests
bparrishMines 155469f
change required to isRequired
bparrishMines 3a45694
improve docs
bparrishMines 6350353
fix lint errors and hide ProxyApi
bparrishMines 5cfcb3a
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 4ce1e21
add hide comment
bparrishMines 22c3065
test for recursive looks
bparrishMines a14485e
fix tools version
bparrishMines 360dd7a
review comments
bparrishMines ea9f7c3
switch to a method that looks for matching prefix
bparrishMines 33b2e07
avoid loops
bparrishMines 6c79879
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines c8db9c8
fix test
bparrishMines b414381
change superClass and interfaces to TypeDeclarations
bparrishMines 00db939
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 54c7ac2
add deps
bparrishMines d05bebf
add proxyapi ast helper gen methods
bparrishMines dfb7e45
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 8015a9a
implementation of proxyapis stuff for dart
bparrishMines 2dac15d
add proxy api base class
bparrishMines 36bbca1
add documentation
bparrishMines afa62e8
add tests and some minor validatation improvements
bparrishMines 1cd4d95
add tests actually
bparrishMines b08d017
generate test api file
bparrishMines fc3df6f
method improvements
bparrishMines 0caa963
add protected for more methods
bparrishMines 1c61c51
improvement of docs
bparrishMines cb2e654
change enum name
bparrishMines 12d9c7d
dont gen method without apis
bparrishMines 8abdb3f
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 1d2c549
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines c0aa558
fix class name generation without underscore
bparrishMines 1f0c6ce
change to indexMap and fix extra space
bparrishMines 7f1f70e
review comments and regen
bparrishMines 2b04aa5
`Merge branch 'main' of github.com:flutter/packages into pigeon_wrapp…
bparrishMines 94106ae
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 796d336
move methods
bparrishMines dcbd085
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 358b6d7
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 0138563
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines ea338c8
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
change enum name
- Loading branch information
commit cb2e6546b65d2e24d364429197475c4e8058bd32
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file makes me want to quit my job. Generally seems like everything is there and makes sense.
I'm torn about whether or not to keep it apart from the other core_tests file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this file is all generated so that I can write the integration tests and verify the generated code doesn't cause any lint warnings. I assumed the review for this file would only require someone to skim it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a sense this is the code that needs the most review, since it's the actual functioning code from what you've written. The rest of it is just preference and future work looking.