Skip to content

[flutter_image] Replace deprecated APIs #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Feb 14, 2024
Merged

[flutter_image] Replace deprecated APIs #6126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/flutter_image/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.1.11

* Replaces deprecated loadBuffer API usage.

## 4.1.10

* Fixes image asset link to use image within package.
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter_image/lib/network.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ class NetworkImageWithRetry extends ImageProvider<NetworkImageWithRetry> {
}

@override
ImageStreamCompleter loadBuffer(
ImageStreamCompleter loadImage(
NetworkImageWithRetry key,
DecoderBufferCallback decode,
ImageDecoderCallback decode,
) {
return OneFrameImageStreamCompleter(_loadWithRetry(key, decode),
informationCollector: () sync* {
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_image/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: >
Image utilities for Flutter: improved network providers, effects, etc.
repository: https://github.com/flutter/packages/tree/main/packages/flutter_image
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_image%22
version: 4.1.10
version: 4.1.11

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/flutter_image/test/network_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ void assertThatImageLoadingFails(
NetworkImageWithRetry subject,
List<FlutterErrorDetails> errorLog,
) {
final ImageStreamCompleter completer = subject.loadBuffer(
final ImageStreamCompleter completer = subject.loadImage(
subject,
PaintingBinding.instance.instantiateImageCodecFromBuffer,
PaintingBinding.instance.instantiateImageCodecWithSize,
);
completer.addListener(ImageStreamListener(
(ImageInfo image, bool synchronousCall) {},
Expand All @@ -157,9 +157,9 @@ void assertThatImageLoadingFails(
void assertThatImageLoadingSucceeds(
NetworkImageWithRetry subject,
) {
final ImageStreamCompleter completer = subject.loadBuffer(
final ImageStreamCompleter completer = subject.loadImage(
subject,
PaintingBinding.instance.instantiateImageCodecFromBuffer,
PaintingBinding.instance.instantiateImageCodecWithSize,
);
completer.addListener(ImageStreamListener(
expectAsync2((ImageInfo image, bool synchronousCall) {
Expand Down