Skip to content

[in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon #6165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 19 commits into from
Feb 21, 2024
Merged

[in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon #6165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7a2a668
prior to native tests
LouiseHsu Feb 15, 2024
3a7fdee
more tests
LouiseHsu Feb 15, 2024
08cba31
finished native tests
LouiseHsu Feb 15, 2024
9a3b25d
tests
LouiseHsu Feb 15, 2024
ca49642
tests passing
LouiseHsu Feb 20, 2024
bff4b77
removing a bunch of unused code
LouiseHsu Feb 20, 2024
c38d2f3
specify ios only test
LouiseHsu Feb 20, 2024
e6d1054
format, pubspec, and copyright
LouiseHsu Feb 20, 2024
6dae4e5
warnings
LouiseHsu Feb 20, 2024
4f941c5
move things around for nicer diff
LouiseHsu Feb 20, 2024
fb644f8
nice diffs, very beautiful diffs
LouiseHsu Feb 21, 2024
03cd82a
versioning conflict
LouiseHsu Feb 21, 2024
1e48d2c
Merge branch 'main' into iap_pigeon_part_3
LouiseHsu Feb 21, 2024
b0aa7cc
pr comments
LouiseHsu Feb 21, 2024
ed67de7
Merge branch 'iap_pigeon_part_3' of github.com:LouiseHsu/packages int…
LouiseHsu Feb 21, 2024
732a2dd
Merge branch 'main' into iap_pigeon_part_3
LouiseHsu Feb 21, 2024
f5b07df
pr comments
LouiseHsu Feb 21, 2024
5891fd4
Merge branch 'iap_pigeon_part_3' of github.com:LouiseHsu/packages int…
LouiseHsu Feb 21, 2024
6d61374
Merge branch 'main' into iap_pigeon_part_3
LouiseHsu Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pr comments
  • Loading branch information
@LouiseHsu
LouiseHsu committed Feb 21, 2024
commit b0aa7cc2df16e94df220cf36d6162844787cfb67
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ - (void)presentCodeRedemptionSheetWithError:
#endif
}

- (NSString *_Nullable)retrieveReceiptDataWithError:
- (nullable NSString *)retrieveReceiptDataWithError:
(FlutterError *_Nullable __autoreleasing *_Nonnull)error {
FlutterError *flutterError;
NSString *receiptData = [self.receiptManager retrieveReceiptWithError:&flutterError];
Expand Down
7 changes: 4 additions & 3 deletions ...p_purchase/in_app_purchase_storekit/example/shared/RunnerTests/InAppPurchasePluginTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ - (void)testRestoreTransactions {

- (void)testRetrieveReceiptDataSuccess {
FlutterError *error;
id result = [self.plugin retrieveReceiptDataWithError:&error];
NSString *result = [self.plugin retrieveReceiptDataWithError:&error];
XCTAssertNotNil(result);
XCTAssert([result isKindOfClass:[NSString class]]);
}
Expand All @@ -295,15 +295,15 @@ - (void)testRetrieveReceiptDataNil {
NSBundle *mockBundle = OCMPartialMock([NSBundle mainBundle]);
OCMStub(mockBundle.appStoreReceiptURL).andReturn(nil);
FlutterError *error;
id result = [self.plugin retrieveReceiptDataWithError:&error];
NSString *result = [self.plugin retrieveReceiptDataWithError:&error];
XCTAssertNil(result);
}

- (void)testRetrieveReceiptDataError {
self.receiptManagerStub.returnError = YES;

FlutterError *error;
id result = [self.plugin retrieveReceiptDataWithError:&error];
NSString *result = [self.plugin retrieveReceiptDataWithError:&error];

XCTAssertNil(result);
XCTAssertNotNil(error);
Expand All @@ -324,6 +324,7 @@ - (void)testRefreshReceiptRequest {
}

#if TARGET_OS_IOS
Copy link
Member

@gaaclarke gaaclarke Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this only for iOS? Add a quick comment in the code if you intended this.

Copy link
Contributor Author

@LouiseHsu LouiseHsu Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/// presentCodeRedemptionSheetWithError:error is only available on iOS
Copy link
Member

@gaaclarke gaaclarke Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this before the #if please?

- (void)testPresentCodeRedemptionSheet {
FIAPaymentQueueHandler *mockHandler = OCMClassMock([FIAPaymentQueueHandler class]);
self.plugin.paymentQueueHandler = mockHandler;
Expand Down