Skip to content

[pigeon] Allows kotlin generator to skip error class generation #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Feb 27, 2024
Merged

[pigeon] Allows kotlin generator to skip error class generation #6183

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf55e6d
add logic to remove test class and update generation to use it
tarrinneal Feb 22, 2024
9211412
update test file
tarrinneal Feb 22, 2024
c5fc5c9
version
tarrinneal Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test file
  • Loading branch information
@tarrinneal
tarrinneal committed Feb 22, 2024
commit 9211412f9636eb78e20dfd0283052d5256d9f0c3
4 changes: 2 additions & 2 deletions .../platform_tests/test_plugin/android/src/main/kotlin/com/example/test_plugin/TestPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class TestPlugin : FlutterPlugin, HostIntegrationCoreApi {
}

override fun throwFlutterError(): Any? {
throw CoreTestsError("code", "message", "details")
throw FlutterError("code", "message", "details")
}

override fun echoInt(anInt: Long): Long {
Expand Down Expand Up @@ -170,7 +170,7 @@ class TestPlugin : FlutterPlugin, HostIntegrationCoreApi {
}

override fun throwAsyncFlutterError(callback: (Result<Any?>) -> Unit) {
callback(Result.failure(CoreTestsError("code", "message", "details")))
callback(Result.failure(FlutterError("code", "message", "details")))
}

override fun echoAsyncAllTypes(everything: AllTypes, callback: (Result<AllTypes>) -> Unit) {
Expand Down