-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[google_map_flutter] Add style to widget - platform impls #6205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 21 commits into
flutter:main
from
stuartmorgan-g:maps-initial-style-implementations
Feb 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
15539cc
Adjust example app for visual repro
stuartmorgan-g fc93d0b
WIP
stuartmorgan-g fedcb40
Pathify platform interface
stuartmorgan-g 1dddbb0
Add style support to MapConfiguration
stuartmorgan-g 2434a00
Add getStyleError
stuartmorgan-g e0355df
Android implementation
stuartmorgan-g be284f3
Improve documentation
stuartmorgan-g 22837ba
Clean up iOS example changes
stuartmorgan-g 7721166
web implementation
stuartmorgan-g d4c9bfb
Plumb through app-facing
stuartmorgan-g dd188d1
Fix test
stuartmorgan-g 2e8a190
version bump
stuartmorgan-g 36a6f84
Autoformat
stuartmorgan-g 1de84db
Use pumpMap for getStyleError test.
ditman ffbfa0a
Merge branch 'main' into maps-initial-style
stuartmorgan-g 953fb8e
Unwind PI overrides
stuartmorgan-g 4a8acf3
Merge remote-tracking branch 'origin/maps-initial-style' into maps-in…
stuartmorgan-g 482918c
Revert app-facing
stuartmorgan-g cf4cc0d
Add another test
stuartmorgan-g e3abef8
Merge branch 'main' into maps-initial-style-implementations
stuartmorgan-g 407c475
Merge branch 'main' into maps-initial-style-implementations
ditman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
web implementation
- Loading branch information
commit 7721166a65fd60a03e93d672612a0a13ce56ff47
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a test that asserts that
_lastStylesremain unchanged whenupdate.styleis wrong? (not sure if we want that to be a feature or is a side-effect of this particular implementation)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does seem worth testing. I couldn't see a way to add it without adding another kind of ugly test hook, so I did that; let me know if you have a better option. (Long term we may want to wrap that opaque maps object instead of having to add these hooks at this layer.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new hook is fine. There seems to exist a way to fetch styles from the gmaps.GMap object through its MVCObject interface:
(
getDartDocs)But I'm not sure if whatever that returns is directly comparable with what we pass in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need to compare with what we pass in, just the before/after, but I'm getting null from that getter. Maybe this is related to needing to pump things differently in the maps integration tests?
For now I'm just going to land this since it's a pattern we already have, and we can revisit the structure of these tests later if necessary.