Skip to content

[webview_flutter_android] Fixes iframe navigation with onNavigationRequest #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
May 1, 2024
Merged

[webview_flutter_android] Fixes iframe navigation with onNavigationRequest #6335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf619d0
Fixes iframe navigation being handled in the main frame when `Navigat…
petermnt Mar 15, 2024
361c19d
Don't send the request to the flutter api for subframes. Also improve…
petermnt Mar 21, 2024
d1d3bd6
Handle not sending the request to the client in the controller
petermnt Mar 27, 2024
9035847
Remove redundant test
petermnt Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove redundant test
  • Loading branch information
@petermnt
petermnt committed Apr 15, 2024
commit 90358477118f165848b1a70dd6c78e5c46c75a6c
3 changes: 1 addition & 2 deletions .../android/src/test/java/io/flutter/plugins/webviewflutter/WebViewClientCompatImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ public class WebViewClientCompatImplTest {

@Mock public WebView mockWebView;

@Mock public WebViewClientCompatImpl mockWebViewClient;

InstanceManager instanceManager;
WebViewClientHostApiImpl hostApiImpl;
WebViewClientCompatImpl webViewClient;
Expand Down Expand Up @@ -161,6 +159,7 @@ public void convertWebResourceRequestWithNullHeaders() {

@Test
public void setReturnValueForShouldOverrideUrlLoading() {
WebViewClientHostApiImpl.WebViewClientCompatImpl mockWebViewClient = mock();
final WebViewClientHostApiImpl webViewClientHostApi =
new WebViewClientHostApiImpl(
instanceManager,
Expand Down
77 changes: 0 additions & 77 deletions ...er_android/android/src/test/java/io/flutter/plugins/webviewflutter/WebViewClientTest.java
View file
Open in desktop

This file was deleted.