Skip to content

[webview_flutter_android] Run tests on API 34 emulators #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camsim99 wants to merge 15 commits into from
Closed

[webview_flutter_android] Run tests on API 34 emulators #6339

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ad19f0a
Remove wf from 33 list
camsim99 Mar 15, 2024
3a5d32d
Isolate failing test
camsim99 Mar 15, 2024
cb8a917
Add logcat
camsim99 Mar 20, 2024
5a70ad7
Isolate adb logcat call
camsim99 Mar 20, 2024
9d4f42a
Add pipe
camsim99 Mar 20, 2024
ecfeaa0
Add slashes
camsim99 Mar 21, 2024
7c3bc52
Increase timeout
camsim99 Mar 25, 2024
3e9428e
bringup true
camsim99 Mar 25, 2024
7d8f42a
retry
camsim99 Mar 26, 2024
154849e
Add debug logs arg to flutter drive call
camsim99 Mar 27, 2024
9dad192
Add verbose logging
camsim99 Mar 29, 2024
ff68a8d
Add flag in right place
camsim99 Apr 1, 2024
a6f1d03
Add prints
camsim99 Apr 9, 2024
12ecf32
Delete legacy
camsim99 Apr 9, 2024
cd0f3d1
await
camsim99 Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
await
  • Loading branch information
@camsim99
camsim99 committed Apr 9, 2024
commit cd0f3d1659f35b9f5261d9e39ce01a4155135440
6 changes: 3 additions & 3 deletions packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,16 +257,16 @@ Future<void> main() async {
WebViewController controller =
WebViewController.fromPlatformCreationParams(params);
print('camille: controller set up');
unawaited(controller.setJavaScriptMode(JavaScriptMode.unrestricted));
await (controller.setJavaScriptMode(JavaScriptMode.unrestricted));
print('camille: set javascript mode');

unawaited(controller.setNavigationDelegate(
await (controller.setNavigationDelegate(
NavigationDelegate(onPageFinished: (_) => pageLoaded.complete()),
));
print('camille: set navigation delegate');

if (controller.platform is AndroidWebViewController) {
unawaited((controller.platform as AndroidWebViewController)
await ((controller.platform as AndroidWebViewController)
.setMediaPlaybackRequiresUserGesture(false));
print('camille: set requires user gesture');
}
Expand Down