Skip to content

[camerax] Use AspectRatioStrategy and ResolutionFilter to help automatic selection of expected resolution #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Mar 27, 2024
Merged

[camerax] Use AspectRatioStrategy and ResolutionFilter to help automatic selection of expected resolution #6357

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fc073eb
Add aspect ratio where I can
camsim99 Mar 19, 2024
a0da398
Start adding tests
camsim99 Mar 19, 2024
3d6a9f1
Add tests
camsim99 Mar 19, 2024
02d8bb0
Bump version
camsim99 Mar 19, 2024
e22de74
Merge remote-tracking branch 'upstream/main' into camx_aspect
camsim99 Mar 20, 2024
4151936
Update packages/camera/camera_android_camerax/lib/src/camerax_proxy.dart
camsim99 Mar 21, 2024
559df9b
Add functionality + java tests
camsim99 Mar 26, 2024
67a324e
Add dart tests
camsim99 Mar 26, 2024
e585343
Merge remote-tracking branch 'upstream/main' into camx_aspect
camsim99 Mar 26, 2024
f45e9d1
Update changelog
camsim99 Mar 26, 2024
92939cd
Merge remote-tracking branch 'refs/remotes/origin/camx_aspect' into c…
camsim99 Mar 26, 2024
196fd89
Nits
camsim99 Mar 26, 2024
29a77d5
Address review
camsim99 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/camera/camera_android_camerax/lib/src/camerax_proxy.dart 
Co-authored-by: Gray Mackall <[email protected]>
  • Loading branch information
@camsim99 @gmackall
camsim99 and gmackall authored Mar 21, 2024
commit 4151936377c22552533a99b028aa4f7e76b16bbc
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/lib/src/camerax_proxy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class CameraXProxy {
Camera2CameraControl Function(CameraControl cameraControl)
getCamera2CameraControl;

/// Create [CaptureRequestOptions] with specified options.
/// Creates a [CaptureRequestOptions] with specified options.
CaptureRequestOptions Function(
List<(CaptureRequestKeySupportedType, Object?)> options)
createCaptureRequestOptions;
Expand Down