Skip to content

[ci] Adds sleep 60s to release action. #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Mar 28, 2024
Merged

[ci] Adds sleep 60s to release action. #6405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ci] Adds sleep 60s to release action. 
As suggested in #137299:

* Adds a 1 minute sleep to our `release.yml` workflow so LUCI checks have time to be populated through the GitHub Webhooks, before attempting to look at them.

This will make the `release` action a little bit slower, but hopefully much more reliable.
  • Loading branch information
@ditman
ditman committed Mar 28, 2024
commit 9cdafa19b126b4dffe191de2975ee0e8488e5655
7 changes: 7 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ jobs:
run: dart pub get
working-directory: ${{ github.workspace }}/script/tool

# Give some time for LUCI checks to start becoming populated.
# Because of latency in Github Webhooks, we need to wait for a while
# before being able to look at checks scheduled by LUCI.
- name: Give webhooks a minute
run: sleep 60s
shell: bash

# The next step waits for all tests, but when there are issues with the
# hooks it can take a long time for the tests to even be registered. If
# "Wait on all tests" runs before that happens, it will pass immediately
Expand Down