Skip to content

Fix unnecessary toList/fromList calls during encode/decode process #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
May 6, 2024
Merged

Fix unnecessary toList/fromList calls during encode/decode process #6426

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a961d01
remove extra encode/decode
tarrinneal Mar 28, 2024
66b7986
update tests
tarrinneal Mar 28, 2024
4880fec
tests, more kotlin stuff
tarrinneal Mar 28, 2024
0588573
some cpp
tarrinneal Mar 29, 2024
01444d0
remove aList
tarrinneal Mar 29, 2024
6b224fe
AList
tarrinneal Mar 29, 2024
da44ff7
Fix custom class reference extraction in deserialization
stuartmorgan-g Apr 4, 2024
78b9548
Fix Dart unit test
stuartmorgan-g Apr 4, 2024
022d463
Update encoding-sensitive native unit tests
stuartmorgan-g Apr 4, 2024
06653f2
Update generated file
stuartmorgan-g Apr 4, 2024
b4468eb
nits and such
tarrinneal Apr 22, 2024
b0d6176
Merge branch 'main' of github.com:flutter/packages into cc
tarrinneal Apr 23, 2024
60d0efc
gen
tarrinneal Apr 23, 2024
43bb4dc
Merge branch 'cc' of github.com:tarrinneal/packages into cc
tarrinneal Apr 23, 2024
1cdfc2a
oops
tarrinneal Apr 23, 2024
42e6773
fix tests
tarrinneal Apr 23, 2024
b402838
VS 2019 workaround
stuartmorgan-g Apr 26, 2024
0c032c6
Apply workaround to unit test binary
stuartmorgan-g Apr 30, 2024
df349c9
cleaner
tarrinneal May 6, 2024
34f9dca
analyze
tarrinneal May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update generated file
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Apr 4, 2024
commit 06653f2341d7a4b7e06f08e7176ba5b29b19134a
15 changes: 9 additions & 6 deletions packages/pigeon/platform_tests/test_plugin/windows/pigeon/core_tests.gen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,8 +689,8 @@ AllNullableTypes AllNullableTypes::FromEncodableList(
}
auto& encodable_all_nullable_types = list[16];
if (!encodable_all_nullable_types.IsNull()) {
decoded.set_all_nullable_types(
std::get<AllNullableTypes>(encodable_all_nullable_types));
decoded.set_all_nullable_types(std::any_cast<const AllNullableTypes&>(
std::get<CustomEncodableValue>(encodable_all_nullable_types)));
}
return decoded;
}
Expand Down Expand Up @@ -1236,16 +1236,19 @@ EncodableList AllClassesWrapper::ToEncodableList() const {

AllClassesWrapper AllClassesWrapper::FromEncodableList(
const EncodableList& list) {
AllClassesWrapper decoded(std::get<AllNullableTypes>(list[0]));
AllClassesWrapper decoded(std::any_cast<const AllNullableTypes&>(
std::get<CustomEncodableValue>(list[0])));
auto& encodable_all_nullable_types_without_recursion = list[1];
if (!encodable_all_nullable_types_without_recursion.IsNull()) {
decoded.set_all_nullable_types_without_recursion(
std::get<AllNullableTypesWithoutRecursion>(
encodable_all_nullable_types_without_recursion));
std::any_cast<const AllNullableTypesWithoutRecursion&>(
std::get<CustomEncodableValue>(
encodable_all_nullable_types_without_recursion)));
}
auto& encodable_all_types = list[2];
if (!encodable_all_types.IsNull()) {
decoded.set_all_types(std::get<AllTypes>(encodable_all_types));
decoded.set_all_types(std::any_cast<const AllTypes&>(
std::get<CustomEncodableValue>(encodable_all_types)));
}
return decoded;
}
Expand Down