Skip to content

[go_router] Add GoRouterState state parameter to GoRouterData.onExit #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Apr 24, 2024
Merged

[go_router] Add GoRouterState state parameter to GoRouterData.onExit #6495

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7b05a77
refactor: Add state to onExit method
ValentinVignal Apr 10, 2024
28c4da1
test: Update the tests
ValentinVignal Apr 10, 2024
1aabcd9
chore: Update version
ValentinVignal Apr 10, 2024
077ac96
Merge remote-tracking branch 'upstream/main' into go-router/add-state…
ValentinVignal Apr 12, 2024
2e755ce
test: Add a test to verify the state provided to onExit
ValentinVignal Apr 12, 2024
ac289b8
doc: Add link to v14 migration guide
ValentinVignal Apr 16, 2024
3b3c61c
Merge remote-tracking branch 'upstream/main' into go-router/add-state…
ValentinVignal Apr 16, 2024
fa58212
Merge branch 'main' into go-router/add-state-to-on-exit
ValentinVignal Apr 18, 2024
bd028e1
Merge branch 'main' into go-router/add-state-to-on-exit
chunhtai Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Update the tests
  • Loading branch information
@ValentinVignal
ValentinVignal committed Apr 10, 2024
commit 28c4da1b5cd815cd8745da45883af7278f4855fe
14 changes: 7 additions & 7 deletions packages/go_router/test/on_exit_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void main() {
path: '1',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: page1),
onExit: (BuildContext context) {
onExit: (BuildContext context, GoRouterState state) {
Copy link
Contributor

@chunhtai chunhtai Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new test that assert the properties in state, to make sure the state is accurate with the route?

return allow;
},
)
Expand Down Expand Up @@ -61,7 +61,7 @@ void main() {
path: '/1',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: page1),
onExit: (BuildContext context) {
onExit: (BuildContext context, GoRouterState state) {
return allow;
},
)
Expand Down Expand Up @@ -95,7 +95,7 @@ void main() {
path: '1',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: page1),
onExit: (BuildContext context) async {
onExit: (BuildContext context, GoRouterState state) async {
return allow.future;
},
)
Expand Down Expand Up @@ -139,7 +139,7 @@ void main() {
path: '/1',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: page1),
onExit: (BuildContext context) async {
onExit: (BuildContext context, GoRouterState state) async {
return allow.future;
},
)
Expand Down Expand Up @@ -176,7 +176,7 @@ void main() {
path: '/',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: home),
onExit: (BuildContext context) {
onExit: (BuildContext context, GoRouterState state) {
return allow;
},
),
Expand All @@ -201,7 +201,7 @@ void main() {
path: '/',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: home),
onExit: (BuildContext context) async {
onExit: (BuildContext context, GoRouterState state) async {
return allow;
},
),
Expand All @@ -227,7 +227,7 @@ void main() {
path: '/',
builder: (BuildContext context, GoRouterState state) =>
DummyScreen(key: home),
onExit: (BuildContext context) {
onExit: (BuildContext context, GoRouterState state) {
return allow;
},
),
Expand Down