Skip to content

[image_picker] Fix If imageToScale is nil, the app will crash (#146682) #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Apr 22, 2024
Merged

[image_picker] Fix If imageToScale is nil, the app will crash (#146682) #6514

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
455f468
[image_picker] Fix If imageToScale is nil, the app will crash (#146682)
zeqinjie Apr 14, 2024
fea7eff
update yaml
zeqinjie Apr 14, 2024
8cbaeef
update format
zeqinjie Apr 15, 2024
73b4788
add test
zeqinjie Apr 15, 2024
3ae6141
update test
zeqinjie Apr 19, 2024
4c4bea9
update
zeqinjie Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update
  • Loading branch information
@zeqinjie
zeqinjie committed Apr 19, 2024
commit 4c4bea993b5a1f531cb804f3ed80edfe418ac4d0
12 changes: 6 additions & 6 deletions packages/image_picker/image_picker_ios/example/ios/RunnerTests/ImageUtilTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,19 +220,19 @@ - (void)testScaledImage_WideImage_ShouldNotBeScaledAboveOriginaWidthOrHeight {
- (void)testScaledImage_ImageIsNil {
UIImage *image = nil;
UIImage *newImage = [FLTImagePickerImageUtil scaledImage:image
maxWidth:@1440
maxHeight:@1440
isMetadataAvailable:YES];
maxWidth:@1440
maxHeight:@1440
isMetadataAvailable:YES];

XCTAssertEqual(newImage, nil);
}

- (void)testScaledImage_ImageMaxWidthZeroAndMaxHeightIsZero {
UIImage *image = [UIImage imageWithData:ImagePickerTestImages.JPGTestData];
UIImage *newImage = [FLTImagePickerImageUtil scaledImage:image
maxWidth:@0
maxHeight:@0
isMetadataAvailable:YES];
maxWidth:@0
maxHeight:@0
isMetadataAvailable:YES];

XCTAssertEqual(newImage, nil);
}
Expand Down