Skip to content

[pigeon][swift] Removes FlutterError in favor of PigeonError #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 25 commits into from
May 16, 2024
Merged

[pigeon][swift] Removes FlutterError in favor of PigeonError #6611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c510bd6
[pigeon] Do not use FlutterError when generating Swift code
hpcnt-daniel-l Apr 25, 2024
d8968d7
[pigeon] Add option to whether emit PigeonError class in Swift code
hpcnt-daniel-l Apr 25, 2024
c2beea1
[pigeon] Simplify localizedDescription of PigeonError in Swift
hpcnt-daniel-l Apr 25, 2024
6a8a94c
[pigeon] Always make sure CoreTests.gen.swift has PigeonError class
hpcnt-daniel-l Apr 25, 2024
b874f09
[pigeon] Make PigeonError class final and add FlutterError initializer
hpcnt-daniel-l Apr 25, 2024
df102e3
[pigeon] Rename swiftEmitErrorClass to emitPigeonErrorClass
hpcnt-daniel-l Apr 25, 2024
b30a0cc
[pigeon] Make wrapError in swift also handle PigeonError
hpcnt-daniel-l Apr 26, 2024
30ac050
[pigeon] Emit Error class for Swift with different names per file
hpcnt-daniel-l Apr 26, 2024
92c97af
[pigeon] Restore docregion for swift-class
hpcnt-daniel-l Apr 26, 2024
86d9168
[pigeon] Add CHANGELOG.md entry
hpcnt-daniel-l Apr 26, 2024
20ac87a
[pigeon] Apply format fix
hpcnt-daniel-l Apr 26, 2024
800ba60
[pigeon] Generate Swift error on CoreTests.gen.swift
hpcnt-daniel-l Apr 26, 2024
8fa6b75
[pigeon] Fix unittests for swift generator
hpcnt-daniel-l Apr 26, 2024
4bd3dbc
[pigeon] Run update-excerpts
hpcnt-daniel-l Apr 26, 2024
fae49ea
[pigeon] Bump version correctly
hpcnt-daniel-l Apr 26, 2024
b386a96
Merge commit 'd670b2c38c8db0a773aa703e7d3f15682e05ad7f' into feature/…
hpcnt-daniel-l May 8, 2024
78c3bb6
Remove conversion from FlutterError to PigeonError in Swift
hpcnt-daniel-l May 9, 2024
f13a06a
Update the comment for the PigeonError class in Swift
hpcnt-daniel-l May 9, 2024
63df915
Update the documentation for using PigeonError in Swift
hpcnt-daniel-l May 9, 2024
428736d
Replace several usage of Indent.nest with Indent.writeScoped
hpcnt-daniel-l May 10, 2024
88cd27d
Update Changelog and README of pigeon package
hpcnt-daniel-l May 10, 2024
a78cae7
Addressing review comments
hpcnt-daniel-l May 10, 2024
4ed7852
Relocate PigeonError class in Swift files
hpcnt-daniel-l May 14, 2024
a8ab4f8
Merge branch 'main' into feature/pigeon-swift-error
tarrinneal May 14, 2024
877015d
Merge branch 'main' into feature/pigeon-swift-error
bc-lee May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pigeon] Bump version correctly
  • Loading branch information
@hpcnt-daniel-l
hpcnt-daniel-l committed Apr 26, 2024
commit fae49eae2ccaa80e1f59150bb743ffaaddd489b6
2 changes: 1 addition & 1 deletion packages/pigeon/lib/generator_tools.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import 'ast.dart';
/// The current version of pigeon.
///
/// This must match the version in pubspec.yaml.
const String pigeonVersion = '18.0.0';
const String pigeonVersion = '19.0.0';

/// Read all the content from [stdin] to a String.
String readStdin() {
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
version: 18.0.0 # This must match the version in lib/generator_tools.dart
version: 19.0.0 # This must match the version in lib/generator_tools.dart

environment:
sdk: ^3.1.0
Expand Down