Skip to content

[go_router] Use the correct configuration to build the state passed to the onExit #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
May 14, 2024
Merged

[go_router] Use the correct configuration to build the state passed to the onExit #6623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c75b949
fix: Use correct config for the on exit
ValentinVignal Apr 29, 2024
4a9dfd1
test: Add tests around state and on exit
ValentinVignal Apr 29, 2024
7aee926
docs: Update version number
ValentinVignal Apr 29, 2024
743c99b
Merge remote-tracking branch 'upstream/main' into go-router/use-corre…
ValentinVignal Apr 30, 2024
560d3f4
refactor: Remove commented code
ValentinVignal Apr 30, 2024
bb8ea59
Merge remote-tracking branch 'upstream/main' into go-router/use-corre…
ValentinVignal May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'upstream/main' into go-router/use-corre… 
…ct-configuration-in-on-exit

# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/pubspec.yaml
  • Loading branch information
@ValentinVignal
ValentinVignal committed May 13, 2024
commit bb8ea594c219e3beefeb214e7cc99f961d45c59e
6 changes: 5 additions & 1 deletion packages/go_router/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## 14.0.3
## 14.1.1

- Fixes correctness of the state provided in the `onExit`.

## 14.1.0

- Adds route redirect to ShellRoutes

## 14.0.2

- Fixes unwanted logs when `hierarchicalLoggingEnabled` was set to `true`.
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: go_router
description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 14.0.3
version: 14.1.1
repository: https://github.com/flutter/packages/tree/main/packages/go_router
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.