add license check back, make podspec check more specific

script/tool/lib/src/license_check_command.dart

@@ -40,7 +40,6 @@ const Set<String> _ignoreSuffixList = <String>{
 // Full basenames of files to ignore.
 const Set<String> _ignoredFullBasenameList = <String>{
   'resource.h', // Generated by VS.
-  'Package.swift', // Swift Package Manifest file.
 };
 
 // Copyright and license regexes for third-party code.

script/tool/lib/src/podspec_check_command.dart

@@ -164,6 +164,11 @@ class PodspecCheckCommand extends PackageLoopingCommand {
   /// Swift. Skips files named "Package.swift", which is a Swift Pacakge Manager
   /// manifest file and does not mean the plugin is written in Swift.
   Future<bool> _hasIOSSwiftCode(RepositoryPackage package) async {
+    final String iosSwiftPackageManifestPath = package
+        .platformDirectory(FlutterPlatform.ios)
+        .childDirectory(package.displayName)
+        .childFile('Package.swift')
+        .path;
     return getFilesForPackage(package).any((File entity) {
       final String relativePath =
           getRelativePosixPath(entity, from: package.directory);
@@ -172,7 +177,7 @@ class PodspecCheckCommand extends PackageLoopingCommand {
         return false;
       }
       final String filePath = entity.path;
-      return entity.basename != 'Package.swift' &&
+      return filePath != iosSwiftPackageManifestPath &&
           path.extension(filePath) == '.swift';
     });
   }

script/tool/test/license_check_command_test.dart

@@ -120,7 +120,6 @@ void main() {
         'foo.mocks.dart',
         // Ignored files.
         'resource.h',
-        'Package.swift',
       ];
 
       for (final String name in ignoredFiles) {
@@ -545,6 +544,23 @@ void main() {
             contains('  third_party/bad.cc'),
           ]));
     });
+
+    test('passes if Package.swift has license blocks', () async {
+      final File checked = root.childFile('Package.swift');
+      checked.createSync();
+      writeLicense(checked, prefix: '// swift-tools-version: 5.9\n');
+
+      final List<String> output =
+          await runCapturingPrint(runner, <String>['license-check']);
+
+      // Sanity check that the test did actually check a file.
+      expect(
+          output,
+          containsAllInOrder(<Matcher>[
+            contains('Checking Package.swift'),
+            contains('All files passed validation!'),
+          ]));
+    });
   });
 }
 

script/tool/test/podspec_check_command_test.dart

@@ -324,7 +324,7 @@ void main() {
         packagesDir,
         extraFiles: <String>[
           'ios/Classes/SomeSwift.swift',
-          'ios/Package.swift',
+          'ios/plugin1/Package.swift',
         ],
       );
       _writeFakePodspec(plugin, 'ios');
@@ -384,12 +384,12 @@ void main() {
           ));
     });
 
-    test('does not require the search paths workaround for Package.swift',
+    test('does not require the search paths workaround for iOS Package.swift',
         () async {
       final RepositoryPackage plugin = createFakePlugin(
         'plugin1',
         packagesDir,
-        extraFiles: <String>['ios/Package.swift'],
+        extraFiles: <String>['ios/plugin1/Package.swift'],
       );
       _writeFakePodspec(plugin, 'ios');