-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[url_launcher][web] Better support for semantics in the Link widget #6711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d3e16ea
[url_launcher][web] Better support for semantics in the Link widget
mdebbar cce04c4
tests
mdebbar b3d16c7
click on mismatched link
mdebbar f684065
more tests
mdebbar c1556cc
semantics tests
mdebbar d98eab2
apply the target attribute on semantic links
mdebbar 66df2e2
always use plural 'semantics'
mdebbar c359fd4
changes to semanticsIdentifier
mdebbar 7fd5b7b
more attributes on <a>
mdebbar 80e7158
more readable
mdebbar 9d02101
correct attribute name 'flt-semantics-identifier'
mdebbar 3b33642
Merge branch 'main' into new_link_semantics
mdebbar 5334922
use the new linkUrl semantics property
mdebbar 9955360
triggerIfReady
mdebbar af67dfc
docs
mdebbar 393776a
Merge branch 'main' into link_semantics
mdebbar 969e697
Merge branch 'main' into link_semantics
mdebbar 2c37827
Merge branch 'main' into link_semantics
mdebbar aa0c3d7
bump minimum sdk version
mdebbar ba6c60f
Merge branch 'main' into link_semantics
mdebbar f296c49
dart format
mdebbar 46ca0e7
Merge branch 'main' into link_semantics
ditman 114731d
Help test pass in wasm
ditman 4cd3f68
dart format .
ditman c203542
Tag as v2.4.0, update CHANGELOG.
ditman c12a920
Update sdk lower bound in example.
ditman 4e703d5
Address PR comments.
ditman 286d33d
Rename signal handlers to onSignalName
ditman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Address PR comments.
- Loading branch information
commit 4e703d5af181532c2a049d5bbb5824b434b07a30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.